From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934651AbdBQPmm (ORCPT ); Fri, 17 Feb 2017 10:42:42 -0500 Received: from mail1.windriver.com ([147.11.146.13]:55707 "EHLO mail1.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933900AbdBQPmk (ORCPT ); Fri, 17 Feb 2017 10:42:40 -0500 Date: Fri, 17 Feb 2017 10:42:07 -0500 From: Paul Gortmaker To: Darren Hart CC: , Andy Shevchenko , Srinivas Pandruvada , Subject: Re: [PATCH] platform: intel_turbo_max_3: make it explicitly non-modular Message-ID: <20170217154207.GQ6993@windriver.com> References: <20170214003700.8978-1-paul.gortmaker@windriver.com> <20170217033712.GA25241@wisp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170217033712.GA25241@wisp> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Re: [PATCH] platform: intel_turbo_max_3: make it explicitly non-modular] On 16/02/2017 (Thu 19:37) Darren Hart wrote: > On Mon, Feb 13, 2017 at 07:37:00PM -0500, Paul Gortmaker wrote: > > The Kconfig currently controlling compilation of this code is: > > > > drivers/platform/x86/Kconfig:config INTEL_TURBO_MAX_3 > > drivers/platform/x86/Kconfig: bool "Intel Turbo Boost Max Technology 3.0 enumeration driver" > > > > ...meaning that it currently is not being built as a module by anyone. > > > > Lets remove the couple traces of modular infrastructure use, so that > > when reading the driver there is no doubt it is builtin-only. > > > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > > > We also delete the MODULE_LICENSE tag etc. since all that information > > was (or is now) contained at the top of the file in the comments. > > > > We do uncover some implicit includes during build coverage that > > were hidden behind the module.h which pulls in a lot of dependants. > > > > Paul, this all looks so very familiar... have we been through this before? Maybe > for another driver... Can't imagine why you'd say that.... :) $ git log --oneline --author=Gortmaker drivers/platform da43bf0c21e5 intel_pmic_gpio: Make explicitly non-modular f48d1496b853 platform/olpc: Make ec explicitly non-modular f52ab44fb748 platform/x86: Make intel_scu_ipc explicitly non-modular 1dda2b42db1b drivers/platform: Convert non-modular pdev_bus to use builtin_platform_driver P. -- > > > Cc: Darren Hart > > Cc: Andy Shevchenko > > Cc: Srinivas Pandruvada > > Srinivas, any objections? > > > Cc: platform-driver-x86@vger.kernel.org > > Signed-off-by: Paul Gortmaker > > --- > > drivers/platform/x86/intel_turbo_max_3.c | 11 +++++------ > > 1 file changed, 5 insertions(+), 6 deletions(-) > > > > diff --git a/drivers/platform/x86/intel_turbo_max_3.c b/drivers/platform/x86/intel_turbo_max_3.c > > index 0103f5b32e34..4f60d8e32a0a 100644 > > --- a/drivers/platform/x86/intel_turbo_max_3.c > > +++ b/drivers/platform/x86/intel_turbo_max_3.c > > @@ -3,6 +3,8 @@ > > * Copyright (c) 2017, Intel Corporation. > > * All rights reserved. > > * > > + * Author: Srinivas Pandruvada > > + * > > * This program is free software; you can redistribute it and/or modify it > > * under the terms and conditions of the GNU General Public License, > > * version 2, as published by the Free Software Foundation. > > @@ -16,7 +18,9 @@ > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > > > #include > > -#include > > +#include > > +#include > > +#include > > #include > > #include > > #include > > @@ -123,7 +127,6 @@ static const struct x86_cpu_id itmt_legacy_cpu_ids[] = { > > ICPU(INTEL_FAM6_BROADWELL_X), > > {} > > }; > > -MODULE_DEVICE_TABLE(x86cpu, itmt_legacy_cpu_ids); > > > > static int __init itmt_legacy_init(void) > > { > > @@ -146,7 +149,3 @@ static int __init itmt_legacy_init(void) > > return 0; > > } > > late_initcall(itmt_legacy_init) > > - > > -MODULE_DESCRIPTION("Intel Turbo Boost Max 3.0 enumeration driver"); > > -MODULE_AUTHOR("Srinivas Pandruvada "); > > -MODULE_LICENSE("GPL v2"); > > -- > > 2.11.0 > > > > > > -- > Darren Hart > Intel Open Source Technology Center