From: Peter Zijlstra <peterz@infradead.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Niklas Cassel <niklas.cassel@axis.com>,
wim@iguana.be, edumazet@google.com,
linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
niklass@axis.com, Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [PATCH] watchdog: softdog: fire watchdog even if softirqs do not get to run
Date: Mon, 20 Feb 2017 09:36:59 +0100 [thread overview]
Message-ID: <20170220083659.GJ6500@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <697d74e9-a492-f4bf-e09f-3c5c7b5708f3@roeck-us.net>
On Sun, Feb 19, 2017 at 08:46:28AM -0800, Guenter Roeck wrote:
> Cc: Wolfram for input.
>
> On 02/17/2017 10:25 AM, Niklas Cassel wrote:
> >From: Niklas Cassel <niklas.cassel@axis.com>
> >
> >Checking for timer expiration is done from the softirq TIMER_SOFTIRQ.
> >
> >Since commit 4cd13c21b207 ("softirq: Let ksoftirqd do its job"),
> >pending softirqs are no longer always handled immediately, instead,
> >if there are pending softirqs, and ksoftirqd is in state TASK_RUNNING,
> >the handling of the softirqs are deferred, and are instead supposed
> >to be handled by ksoftirqd, when ksoftirqd gets scheduled.
> >
> >If a user space process with a real-time policy starts to misbehave
> >by never relinquishing the CPU while ksoftirqd is in state TASK_RUNNING,
> >what will happen is that all softirqs will get deferred, while ksoftirqd,
> >which is supposed to handle the deferred softirqs, will never get to run.
> >
> >To make sure that the watchdog is able to fire even when we do not get
> >to run softirqs, replace the timers with hrtimers.
> >
>
> This makes the driver dependent on HIGH_RES_TIMERS, which is not available
> on all architectures. Before adding that restriction, I would like to see
> some discussion if this is the only feasible solution.
>
It does no such thing; the hrtimer interface is always available.
next prev parent reply other threads:[~2017-02-20 8:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 18:25 [PATCH] watchdog: softdog: fire watchdog even if softirqs do not get to run Niklas Cassel
2017-02-19 16:46 ` Guenter Roeck
2017-02-20 8:36 ` Peter Zijlstra [this message]
2017-02-20 9:02 ` Guenter Roeck
2017-02-20 10:03 ` Niklas Cassel
2017-02-20 15:31 ` Guenter Roeck
2017-02-20 15:35 ` Guenter Roeck
2017-02-27 4:04 ` Guenter Roeck
2017-02-27 12:58 ` Niklas Cassel
2017-02-27 14:31 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220083659.GJ6500@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=niklas.cassel@axis.com \
--cc=niklass@axis.com \
--cc=wim@iguana.be \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox