From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752476AbdBTKqo (ORCPT ); Mon, 20 Feb 2017 05:46:44 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:33683 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147AbdBTKqm (ORCPT ); Mon, 20 Feb 2017 05:46:42 -0500 Date: Mon, 20 Feb 2017 16:16:36 +0530 From: Saurabh Badhwar To: linux-kernel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org Subject: [PATCH v2] tools/vm: Fix possible resource leak in page_owner_sort.c Message-ID: <20170220104636.GA4607@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch addresses explicit closing of file pointers on exit and redirects the errors to the stderr Signed-off-by: Saurabh Badhwar --- tools/vm/page_owner_sort.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/vm/page_owner_sort.c b/tools/vm/page_owner_sort.c index 8346261..b3c3efa 100644 --- a/tools/vm/page_owner_sort.c +++ b/tools/vm/page_owner_sort.c @@ -109,7 +109,7 @@ int main(int argc, char **argv) list = malloc(max_size * sizeof(*list)); buf = malloc(BUF_SIZE); if (!list || !buf) { - printf("Out of memory\n"); + perror("Unable to allocate memory: "); fclose(fin); fclose(fout); exit(1); @@ -145,8 +145,8 @@ int main(int argc, char **argv) qsort(list2, count, sizeof(list[0]), compare_num); for (i = 0; i < count; i++) - fprintf(fout, "%d times:\n%s\n", list2[i].num, list2[i].txt); - + fprintf(fout, "%d times:\n%s\n", list2[i].num, list2[i].txt); + fclose(fout); return 0; } -- 2.9.3