From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753801AbdBTQcW (ORCPT ); Mon, 20 Feb 2017 11:32:22 -0500 Received: from muru.com ([72.249.23.125]:35908 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752581AbdBTQcU (ORCPT ); Mon, 20 Feb 2017 11:32:20 -0500 Date: Mon, 20 Feb 2017 08:31:56 -0800 From: Tony Lindgren To: Sebastian Reichel Cc: Alessandro Zummo , Alexandre Belloni , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] rtc: cpcap: new rtc driver Message-ID: <20170220163155.GH21809@atomide.com> References: <20170220073535.27393-1-sre@kernel.org> <20170220073535.27393-2-sre@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170220073535.27393-2-sre@kernel.org> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Sebastian Reichel [170219 23:37]: > This driver supports the Motorola CPCAP PMIC found on > some of Motorola's mobile phones, such as the Droid 4. Hey that's cool, works for me for reading and setting date :) Just noticed one thing, see below. > +Requires node properties: > +- compatible: should contain "motorola,cpcap-rtc" > +- interrupts: An interrupt specifier for alarm and 1 Hz irq > + > +Example: > + > +cpcap_rtc: rtc { > + compatible = "motorola,cpcap-rtc"; > + interrupts = <39 IRQ_TYPE_NONE>, <26 IRQ_TYPE_NONE>; > +}; I tried rtcwake -s 3, but got the following: rtcwake: cannot open /sys/class/rtc/rtc0/device/power/wakeup: No such file or directory rtcwake: /dev/rtc0 not enabled for wakeup events Then tried adding "wakeup-source" to above but I think the driver needs something, maybe probably just PM ops? Regards, Tony