From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751872AbdBTSGA (ORCPT ); Mon, 20 Feb 2017 13:06:00 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:37552 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbdBTSF7 (ORCPT ); Mon, 20 Feb 2017 13:05:59 -0500 Date: Mon, 20 Feb 2017 18:55:06 +0100 From: Greg Kroah-Hartman To: Valentin Huebner Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: board: Fix macro code style error Message-ID: <20170220175506.GA30142@kroah.com> References: <20170220174450.GA106887@ubuntu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170220174450.GA106887@ubuntu> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 20, 2017 at 05:44:50PM +0000, Valentin Huebner wrote: > Fixes a 'macro with flow control statement' checkpatch code style > error by removing the board_staging() macro and replacing its two > calls checkpatch is wrong here, you are now adding more lines than you remove: > Signed-off-by: Valentin Hübner > --- > drivers/staging/board/armadillo800eva.c | 10 +++++++++- > drivers/staging/board/board.h | 11 ----------- > drivers/staging/board/kzm9d.c | 10 +++++++++- > 3 files changed, 18 insertions(+), 13 deletions(-) See? There's nothing wrong with the macro as-is, it's like many other macros we have for module init sequences. checkpatch is just a hint, you still have to use your brain :) sorry, greg k-h