From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751242AbdBTXx3 (ORCPT ); Mon, 20 Feb 2017 18:53:29 -0500 Received: from gateway36.websitewelcome.com ([50.116.126.2]:47170 "EHLO gateway36.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750923AbdBTXx2 (ORCPT ); Mon, 20 Feb 2017 18:53:28 -0500 X-Greylist: delayed 1458 seconds by postgrey-1.27 at vger.kernel.org; Mon, 20 Feb 2017 18:53:27 EST Date: Mon, 20 Feb 2017 17:28:46 -0600 From: "Gustavo A. R. Silva" To: gregkh@linuxfoundation.org, wsa-dev@sang-engineering.com, tj@kernel.org, bhaktipriya96@gmail.com Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Senna Tschudin , "Gustavo A. R. Silva" Subject: [PATCH] usb: misc: remove unnecessary code Message-ID: <20170220232846.GA5321@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.253.171 X-Exim-ID: 1cfxNw-000OzG-9o X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-253-171.static.axtel.net (embeddedgus) [187.162.253.171]:44946 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 22 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'val' is an unsigned variable, and less-than-zero comparison of an unsigned variable is never true. Addresses-Coverity-ID: 1230257 Signed-off-by: Gustavo A. R. Silva --- drivers/usb/misc/lvstest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/misc/lvstest.c b/drivers/usb/misc/lvstest.c index c7c2104..6f37610 100644 --- a/drivers/usb/misc/lvstest.c +++ b/drivers/usb/misc/lvstest.c @@ -193,7 +193,7 @@ static ssize_t u2_timeout_store(struct device *dev, return ret; } - if (val < 0 || val > 127) + if (val > 127) return -EINVAL; ret = lvs_rh_set_port_feature(hdev, lvs->portnum | (val << 8), -- 2.5.0