From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531AbdBUFSn (ORCPT ); Tue, 21 Feb 2017 00:18:43 -0500 Received: from gateway31.websitewelcome.com ([192.185.143.39]:41291 "EHLO gateway31.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbdBUFSZ (ORCPT ); Tue, 21 Feb 2017 00:18:25 -0500 Date: Mon, 20 Feb 2017 23:17:36 -0600 From: "Gustavo A. R. Silva" To: lgirdwood@gmail.com, broonie@kernel.org, support.opensource@diasemi.com Cc: linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" , Peter Senna Tschudin Subject: [PATCH] regulator: remove unnecessary code Message-ID: <20170221051736.GA7991@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.152.172.203 X-Exim-ID: 1cg2pm-000HhO-Om X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [189.152.172.203]:56844 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 4 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The name of an array used by itself will always return the array's address. So it makes no sense to evaluate it, since the test will always evaluate as true. Addresses-Coverity-ID: 751412 Signed-off-by: Gustavo A. R. Silva --- drivers/regulator/da9055-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/da9055-regulator.c b/drivers/regulator/da9055-regulator.c index d029c94..a118f63 100644 --- a/drivers/regulator/da9055-regulator.c +++ b/drivers/regulator/da9055-regulator.c @@ -612,7 +612,7 @@ static int da9055_regulator_probe(struct platform_device *pdev) config.driver_data = regulator; config.regmap = da9055->regmap; - if (pdata && pdata->regulators) { + if (pdata) { config.init_data = pdata->regulators[pdev->id]; } else { ret = da9055_regulator_dt_init(pdev, regulator, &config, -- 2.5.0