From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752748AbdBUWLn (ORCPT ); Tue, 21 Feb 2017 17:11:43 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:36452 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751431AbdBUWLd (ORCPT ); Tue, 21 Feb 2017 17:11:33 -0500 Date: Tue, 21 Feb 2017 23:11:28 +0100 From: Peter Senna Tschudin To: "Gustavo A. R. Silva" Cc: gregkh@linuxfoundation.org, wsa-dev@sang-engineering.com, tj@kernel.org, bhaktipriya96@gmail.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: misc: remove unnecessary code Message-ID: <20170221221128.GC13525@gmail.com> References: <20170220232846.GA5321@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170220232846.GA5321@embeddedgus> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 20, 2017 at 05:28:46PM -0600, Gustavo A. R. Silva wrote: > 'val' is an unsigned variable, and less-than-zero comparison of an unsigned > variable is never true. I would add that val is set by kstrtoul() that converts a string to an unsigned long. > > Addresses-Coverity-ID: 1230257 Reviewed-by: Peter Senna Tschudin > Signed-off-by: Gustavo A. R. Silva > --- > drivers/usb/misc/lvstest.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/misc/lvstest.c b/drivers/usb/misc/lvstest.c > index c7c2104..6f37610 100644 > --- a/drivers/usb/misc/lvstest.c > +++ b/drivers/usb/misc/lvstest.c > @@ -193,7 +193,7 @@ static ssize_t u2_timeout_store(struct device *dev, > return ret; > } > > - if (val < 0 || val > 127) > + if (val > 127) > return -EINVAL; > > ret = lvs_rh_set_port_feature(hdev, lvs->portnum | (val << 8), > -- > 2.5.0 >