From: "Tobin C. Harding" <me@tobin.cc>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
Subject: checkpatch suspected false positive
Date: Wed, 22 Feb 2017 10:01:48 +1100 [thread overview]
Message-ID: <20170221230148.GA25711@eros> (raw)
Checkpatch may be giving a false positive of type CONST_STRUCT when
parsing files in drivers/staging/comedi/drivers.
$ pwd
build/kernel/linux-trees/gregKH/staging/
$ cd drivers/staging/comedi/drivers
$ checkpatch --terse --show-types *.c | grep CONST_STRUCT
addi_apci_3501.c:97: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
das16.c:972: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
das16.c:1006: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
jr3_pci.c:659: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
jr3_pci.c:667: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
jr3_pci.c:668: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
ni_670x.c:212: WARNING:CONST_STRUCT: struct comedi_lrange should normally be const
snippet from das16.c
/* get any user-defined input range */
if (pg_type == das16_pg_none && (min || max)) {
struct comedi_lrange *lrange;
struct comedi_krange *krange;
/* allocate single-range range table */
lrange = comedi_alloc_spriv(s, sizeof(*lrange) + sizeof(*krange));
if (!lrange)
return &range_unknown;
/* initialize ai range */
lrange->length = 1;
krange = lrange->range;
krange->min = min;
krange->max = max;
krange->flags = UNIT_volt;
return lrange;
}
>From snippet it may be seen that struct comedi_lrange *lrange should
not be const.
In the event that I am in the wrong and checkpatch is correct please
feel free to bluntly correct me.
thanks,
Tobin.
next reply other threads:[~2017-02-21 23:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 23:01 Tobin C. Harding [this message]
2017-02-21 23:19 ` checkpatch suspected false positive Joe Perches
2017-02-21 23:52 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221230148.GA25711@eros \
--to=me@tobin.cc \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox