From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753907AbdBVClD (ORCPT ); Tue, 21 Feb 2017 21:41:03 -0500 Received: from mga14.intel.com ([192.55.52.115]:23579 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752397AbdBVCk6 (ORCPT ); Tue, 21 Feb 2017 21:40:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,192,1484035200"; d="scan'208";a="60965823" Date: Wed, 22 Feb 2017 08:11:41 +0530 From: Vinod Koul To: Matthias Reichl , Stephen Warren , Lee Jones , Eric Anholt , Martin Sperl , Clive Messer , dmaengine@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH] dmaengine: bcm2835: Fix cyclic DMA period splitting Message-ID: <20170222024140.GV2843@localhost> References: <20170220190115.GB4170@camel2.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170220190115.GB4170@camel2.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 20, 2017 at 08:01:16PM +0100, Matthias Reichl wrote: > The code responsible for splitting periods into chunks that > can be handled by the DMA controller missed to update total_len, > the number of bytes processed in the current period, when there > are more chunks to follow. > > Therefore total_len was stuck at 0 and the code didn't work at all. > This resulted in a wrong control block layout and audio issues because > the cyclic DMA callback wasn't executing on period boundaries. > > Fix this by adding the missing total_len update. Applied, thanks -- ~Vinod