From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932297AbdBVKiO (ORCPT ); Wed, 22 Feb 2017 05:38:14 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35350 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753338AbdBVKiF (ORCPT ); Wed, 22 Feb 2017 05:38:05 -0500 X-ME-Sender: X-Sasl-enc: j5beFipkoKXVvyoNY9VlvbHghGSrHmWi2CZ+s5dWZx6U 1487759883 Date: Wed, 22 Feb 2017 21:37:59 +1100 From: "Tobin C. Harding" To: Takashi Iwai Cc: Jaroslav Kysela , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: emu10k1: Remove cast from memory allocation Message-ID: <20170222103759.GC30091@eros> References: <1487746036-18181-1-git-send-email-me@tobin.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 22, 2017 at 07:59:57AM +0100, Takashi Iwai wrote: > On Wed, 22 Feb 2017 07:47:16 +0100, > Tobin C. Harding wrote: > > > > Coccinelle emits multiple WARNING: casting value returned by memory allocation > > function to (u_int32_t __user *) is useless. > > > > Remove unnecessary cast. > > > > Signed-off-by: Tobin C. Harding > > __user annotation requires the explicit cast. Ok, thanks for reviewing. Tobin. > > > Takashi > > > > --- > > sound/pci/emu10k1/emufx.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/sound/pci/emu10k1/emufx.c b/sound/pci/emu10k1/emufx.c > > index 56fc47b..8a39a6f 100644 > > --- a/sound/pci/emu10k1/emufx.c > > +++ b/sound/pci/emu10k1/emufx.c > > @@ -1186,8 +1186,8 @@ static int _snd_emu10k1_audigy_init_efx(struct snd_emu10k1 *emu) > > if (!icode) > > return err; > > > > - icode->gpr_map = (u_int32_t __user *) kcalloc(512 + 256 + 256 + 2 * 1024, > > - sizeof(u_int32_t), GFP_KERNEL); > > + icode->gpr_map = kcalloc(512 + 256 + 256 + 2 * 1024, > > + sizeof(u_int32_t), GFP_KERNEL); > > if (!icode->gpr_map) > > goto __err_gpr; > > controls = kcalloc(SND_EMU10K1_GPR_CONTROLS, > > @@ -1824,8 +1824,8 @@ static int _snd_emu10k1_init_efx(struct snd_emu10k1 *emu) > > if (!icode) > > return err; > > > > - icode->gpr_map = (u_int32_t __user *) kcalloc(256 + 160 + 160 + 2 * 512, > > - sizeof(u_int32_t), GFP_KERNEL); > > + icode->gpr_map = kcalloc(256 + 160 + 160 + 2 * 512, > > + sizeof(u_int32_t), GFP_KERNEL); > > if (!icode->gpr_map) > > goto __err_gpr; > > > > -- > > 2.7.4 > > > > -- Tobin Harding http://tobin.cc