From: Minchan Kim <minchan@kernel.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, kernel-team@lge.com,
Matthew Wilcox <willy@infradead.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] mm: do not access page->mapping directly on page_endio
Date: Wed, 22 Feb 2017 23:35:17 +0900 [thread overview]
Message-ID: <20170222143517.GA18974@bbox> (raw)
In-Reply-To: <20170222121100.GA7954@dhcp22.suse.cz>
On Wed, Feb 22, 2017 at 01:11:00PM +0100, Michal Hocko wrote:
> On Wed 22-02-17 14:39:24, Minchan Kim wrote:
> > With rw_page, page_endio is used for completing IO on a page
> > and it propagates write error to the address space if the IO
> > fails. The problem is it accesses page->mapping directly which
> > might be okay for file-backed pages but it shouldn't for
> > anonymous page. Otherwise, it can corrupt one of field from
> > anon_vma under us and system goes panic randomly.
>
> I was about to say that anonymous pages shouldn't hit that path because
> the end_swap_bio_write doesn call page_endio. But then I've noticed that
No. For driver to support rw_page, every swap_writepage calls rw_page.
swap_writepage
bdev_writepage
ops->rw_page
> zram does call this function. On a closer look, though, it doesn't seem
> to call it with err != 0 so it cannot hit this path. So I am wondering
> whether this actually fixes anything. Why it has been marked for stable?
Look at other drivers to support rw_page, not zram, esp, brd.
They can be used for swap device and then can hit the case.
In fact, I encountered the BUG during zram development(i.e., it doesn't
land to upstream) and it was really hard to figure it out because it made
random crash, sometime mmap_sem lockdep, sometime other places where
places never related to zram/zsmalloc, sometime not reproducible.
When I consider how that bug is subtle and people do fast-swap test as brd,
it's worth to add stable mark, I think.
next prev parent reply other threads:[~2017-02-22 14:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 5:39 [PATCH] mm: do not access page->mapping directly on page_endio Minchan Kim
2017-02-22 12:11 ` Michal Hocko
2017-02-22 14:35 ` Minchan Kim [this message]
2017-02-22 14:53 ` Michal Hocko
2017-02-23 23:26 ` Minchan Kim
2017-02-24 9:13 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170222143517.GA18974@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@kernel.org \
--cc=stable@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox