From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932932AbdBVPqV (ORCPT ); Wed, 22 Feb 2017 10:46:21 -0500 Received: from mail.kernel.org ([198.145.29.136]:33982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932631AbdBVPqN (ORCPT ); Wed, 22 Feb 2017 10:46:13 -0500 Date: Wed, 22 Feb 2017 12:37:54 -0300 From: Arnaldo Carvalho de Melo To: "Reshetova, Elena" Cc: "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , "peterz@infradead.org" , "gregkh@linuxfoundation.org" , "mingo@redhat.com" , "alexander.shishkin@linux.intel.com" , "jolsa@kernel.org" , "mark.rutland@arm.com" , "akpm@linux-foundation.org" , "matija.glavinic-pecotic.ext@nokia.com" , Hans Liljestrand , Kees Cook , David Windsor Subject: Re: [PATCH 1/9] tools: convert cgroup_sel.refcnt from atomic_t to refcount_t Message-ID: <20170222153754.GA20447@kernel.org> References: <1487691303-31858-1-git-send-email-elena.reshetova@intel.com> <1487691303-31858-2-git-send-email-elena.reshetova@intel.com> <20170221154356.GF5052@kernel.org> <2236FBA76BA1254E88B949DDB74E612B41C4EC7E@IRSMSX102.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2236FBA76BA1254E88B949DDB74E612B41C4EC7E@IRSMSX102.ger.corp.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Feb 22, 2017 at 02:29:18PM +0000, Reshetova, Elena escreveu: > > Em Tue, Feb 21, 2017 at 05:34:55PM +0200, Elena Reshetova escreveu: > > > refcount_t type and corresponding API should be > > > used instead of atomic_t when the variable is used as > > > a reference counter. This allows to avoid accidental > > > refcounter overflows that might lead to use-after-free > > > situations. > > > #define __CGROUP_H__ > > > > > > -#include > > > +#include > > > > So this is the first one, I was expecting the copy from > > include/linux/refcount.h to be made to tools/include/linux/refcount.h, > > as was done for tools/include/linux/atomic.h and all the other stuff in > > tools/include/ > > > > See: > > > > commit c4b6014e8bb0c8d47fe5c71ebc604f31091e5d3f > > Author: Arnaldo Carvalho de Melo > > Date: Mon Jul 11 10:28:48 2016 -0300 > > > > tools: Add copy of perf_event.h to tools/include/linux/ > > > > -------------- > > > > For one of the reasons we've been doing this. > Hm.. I have taken a look on it and I am confused. refcount.h is not > exactly standalone header and seems to bring in quite some many > dependencies to other headers (linux/bug.h, linux/mutex.h etc.), which > are not present in tools headers dirs. > I tried to compile perf tool as a start, copied the refcount.h to > tools/include/linux/ and somewhere after it wanted me to bring the > 10th header I stopped, because this cannot be right, or? So, it doesn't have to be a straight copy, and it just shows the problem with using the kernel headers directly, i.e. tools/perf/ uses atomic.h, and uses that for refcounting, but not all of include/linux/refcount.h should be copied to tools/include/linux/refcount.h. I'll try doing the work, that way I'll read about this new stuff, will come back here with what I find, so you can continue on the kernel bits for now, ok? - Arnaldo