From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934479AbdBVVTr (ORCPT ); Wed, 22 Feb 2017 16:19:47 -0500 Received: from mga09.intel.com ([134.134.136.24]:43713 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932651AbdBVVTj (ORCPT ); Wed, 22 Feb 2017 16:19:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,196,1484035200"; d="scan'208";a="936990914" Date: Wed, 22 Feb 2017 23:19:24 +0200 From: Jarkko Sakkinen To: Peter Huewe Cc: Jason Gunthorpe , tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, peterhuewe@gmx.de, Christophe Ricard Subject: Re: [PATCH 0/5] Fix whole native SPI TPM driver Message-ID: <20170222211924.zdikc5qfzuxiggte@intel.com> References: <1487261306-2494-1-git-send-email-peter.huewe@infineon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487261306-2494-1-git-send-email-peter.huewe@infineon.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 16, 2017 at 04:08:21PM +0000, Peter Huewe wrote: > During our testing it showed that unfortunately the whole native spi tpm driver > was more or less non-functional since it was merged, e.g. the wrong byte for > waitstate handling was used and transfers larger than 64 bytes did not work at all. > > This was probably caused by the merging of the different approaches back then, > as the initial RFC patch did not have these problems, and also my sudden lack > of time/commitment back then. > I'm sorry that the final driver code went untested for that long time. > > This patch set fixes these issues one by one. > In order to avoid duplication the read/write function was consolidated to one > transfer function, so we do not have to apply the same fix at two locations. > Maybe consider squashing it - we splitted it for easier review. > > Affected Kernels: 4.8, 4.9, 4.10 > Patchset was tested on Raspberry Pi2 with SLB9670 (TPM1.2 and TPM2.0) > > Peter Huewe (5): > tpm_tis_spi: Use single function to transfer data > tpm_tis_spi: Abort transfer when too many wait states are signaled > tpm_tis_spi: Check correct byte for wait state indicator > tpm_tis_spi: Remove limitation of transfers to MAX_SPI_FRAMESIZE bytes > tpm_tis_spi: Add small delay after last transfer > > drivers/char/tpm/tpm_tis_spi.c | 163 +++++++++++++++++------------------------ > 1 file changed, 69 insertions(+), 94 deletions(-) > > -- > 2.7.4 > I also found type errors a whilea ago: https://patchwork.kernel.org/patch/9547993/ Do this take care of these issues? /JArkko