From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934509AbdBWCDX (ORCPT ); Wed, 22 Feb 2017 21:03:23 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:43673 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932692AbdBWCDP (ORCPT ); Wed, 22 Feb 2017 21:03:15 -0500 X-ME-Sender: X-Sasl-enc: I1bgJxx1sKWx4hWYpeYNobAmE5OOMbagg2/qFRiwDkFM 1487815309 Date: Thu, 23 Feb 2017 13:01:45 +1100 From: "Tobin C. Harding" To: Arushi Singhal Cc: arnaud.patard@rtp-net.org, devel@driverdev.osuosl.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name Message-ID: <20170223020145.GA10075@eros> References: <20170222181639.GA30190@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170222181639.GA30190@arushi-HP-Pavilion-Notebook> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Please use the imperative mood in the subject line i.e the short form of git commit log. A couple of example Subjects:: Subject: [PATCH 2/5] ext2: improve scalability of bitmap searching Subject: [PATCH v2 01/27] x86: fix eflags tracking Awesome work on you patches! thanks, Tobin.