* [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name
@ 2017-02-22 18:16 Arushi Singhal
2017-02-23 2:01 ` Tobin C. Harding
2017-02-24 16:49 ` Greg Kroah-Hartman
0 siblings, 2 replies; 3+ messages in thread
From: Arushi Singhal @ 2017-02-22 18:16 UTC (permalink / raw)
To: arnaud.patard; +Cc: Greg Kroah-Hartman, devel, linux-kernel, outreachy-kernel
function prototype argument 'struct vb_device_info *' and 'unsigned
long' should also have an identifier name.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v3
-make the subject title more relevant.
-change the identifier of struct vb_device_info to XGI_Pr.
---
drivers/staging/xgifb/vb_init.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/vb_init.h b/drivers/staging/xgifb/vb_init.h
index 500cabe41a3c..e835054b87bf 100644
--- a/drivers/staging/xgifb/vb_init.h
+++ b/drivers/staging/xgifb/vb_init.h
@@ -1,6 +1,5 @@
#ifndef _VBINIT_
#define _VBINIT_
unsigned char XGIInitNew(struct pci_dev *pdev);
-void XGIRegInit(struct vb_device_info *, unsigned long);
+void XGIRegInit(struct vb_device_info *XGI_Pr, unsigned long BaseAddr);
#endif
-
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name
2017-02-22 18:16 [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name Arushi Singhal
@ 2017-02-23 2:01 ` Tobin C. Harding
2017-02-24 16:49 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Tobin C. Harding @ 2017-02-23 2:01 UTC (permalink / raw)
To: Arushi Singhal
Cc: arnaud.patard, devel, Greg Kroah-Hartman, linux-kernel,
outreachy-kernel
Please use the imperative mood in the subject line i.e the short form
of git commit log.
A couple of example Subjects::
Subject: [PATCH 2/5] ext2: improve scalability of bitmap searching
Subject: [PATCH v2 01/27] x86: fix eflags tracking
Awesome work on you patches!
thanks,
Tobin.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name
2017-02-22 18:16 [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name Arushi Singhal
2017-02-23 2:01 ` Tobin C. Harding
@ 2017-02-24 16:49 ` Greg Kroah-Hartman
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2017-02-24 16:49 UTC (permalink / raw)
To: Arushi Singhal; +Cc: arnaud.patard, devel, linux-kernel, outreachy-kernel
On Wed, Feb 22, 2017 at 11:46:39PM +0530, Arushi Singhal wrote:
> function prototype argument 'struct vb_device_info *' and 'unsigned
> long' should also have an identifier name.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> changes in v3
> -make the subject title more relevant.
> -change the identifier of struct vb_device_info to XGI_Pr.
> ---
> drivers/staging/xgifb/vb_init.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Does not apply to my tree :(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-24 16:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-22 18:16 [PATCH v3] staging: xgifb: function prototype argument should also have an identifier name Arushi Singhal
2017-02-23 2:01 ` Tobin C. Harding
2017-02-24 16:49 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox