From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751232AbdBWImD (ORCPT ); Thu, 23 Feb 2017 03:42:03 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34364 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbdBWImA (ORCPT ); Thu, 23 Feb 2017 03:42:00 -0500 Date: Thu, 23 Feb 2017 00:41:18 -0800 From: Dmitry Torokhov To: michael.hennerich@analog.com Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/4] input:touchscreen:ad7879-spi.c: Remove bits_per_word = 16 enforcement Message-ID: <20170223084118.GH18639@dtor-ws> References: <1487780078-18510-1-git-send-email-michael.hennerich@analog.com> <1487780078-18510-3-git-send-email-michael.hennerich@analog.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487780078-18510-3-git-send-email-michael.hennerich@analog.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 22, 2017 at 05:14:36PM +0100, michael.hennerich@analog.com wrote: > From: Michael Hennerich > > Using regmap this is no longer required. > > Signed-off-by: Michael Hennerich This gave me warnings about unused "err" variable, I removed it and applied, thank you. > --- > drivers/input/touchscreen/ad7879-spi.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c > index b995891..904a2c2 100644 > --- a/drivers/input/touchscreen/ad7879-spi.c > +++ b/drivers/input/touchscreen/ad7879-spi.c > @@ -42,13 +42,6 @@ static int ad7879_spi_probe(struct spi_device *spi) > return -EINVAL; > } > > - spi->bits_per_word = 16; > - err = spi_setup(spi); > - if (err) { > - dev_dbg(&spi->dev, "spi master doesn't support 16 bits/word\n"); > - return err; > - } > - > regmap = devm_regmap_init_spi(spi, &ad7879_spi_regmap_config); > if (IS_ERR(regmap)) > return PTR_ERR(regmap); > -- > 2.7.4 > -- Dmitry