From: Will Deacon <will.deacon@arm.com>
To: Shanker Donthineni <shankerd@codeaurora.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
James Morse <james.morse@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Vikram Sethi <vikrams@codeaurora.org>
Subject: Re: [PATCH] arm64: Fix the kernel panic() on QDF2400 platform
Date: Thu, 23 Feb 2017 14:45:50 +0000 [thread overview]
Message-ID: <20170223144550.GE27512@arm.com> (raw)
In-Reply-To: <1487819448-8715-1-git-send-email-shankerd@codeaurora.org>
On Wed, Feb 22, 2017 at 09:10:48PM -0600, Shanker Donthineni wrote:
> The commit 38fd94b0 'arm64: Work around Falkor erratum 1003' has
> been added to fix the hardware bug but causing a system crash.
> The value of the register x1 which contains 'struct mm_struct *'
> should be preserved inside macro pre_ttbr0_update_workaround.
>
> Macro pre_ttbr0_update_workaround expects 2nd and 3rd arguments
> are temporary registers. Don't clobber register x1, Otherwise
> the next load operation 'mmid x1 x1' access the invalid address.
Whilst I'm pleased that you've sent a fix (and I'll pick it up), I have
to ask... did anybody actually test the original patch? If so, why wasn't
this found earlier?
Will
next prev parent reply other threads:[~2017-02-23 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-23 3:10 [PATCH] arm64: Fix the kernel panic() on QDF2400 platform Shanker Donthineni
2017-02-23 14:45 ` Will Deacon [this message]
2017-02-23 19:29 ` Timur Tabi
2017-02-23 17:57 ` Manoj Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223144550.GE27512@arm.com \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shankerd@codeaurora.org \
--cc=vikrams@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox