From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbdBXAO0 (ORCPT ); Thu, 23 Feb 2017 19:14:26 -0500 Received: from mga03.intel.com ([134.134.136.65]:40713 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752107AbdBXALB (ORCPT ); Thu, 23 Feb 2017 19:11:01 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,199,1484035200"; d="scan'208";a="1114884880" From: Andi Kleen To: acme@kernel.org Cc: jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: [PATCH 09/10] perf, tools, list: Support printing MetricExpr with -v Date: Thu, 23 Feb 2017 16:10:20 -0800 Message-Id: <20170224001021.6723-9-andi@firstfloor.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170224001021.6723-1-andi@firstfloor.org> References: <20170224001021.6723-1-andi@firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andi Kleen Output the metric expr in perf list when -v is specified, so that the user can check the formula. Before: % perf list -v ... unc_m_power_channel_ppd [Cycles where DRAM ranks are in power down (CKE) mode. Derived from unc_m_power_channel_ppd. Unit: uncore_imc] uncore_imc_2/event=0x85/ After: % perf list -v ... unc_m_power_channel_ppd [Cycles where DRAM ranks are in power down (CKE) mode. Derived from unc_m_power_channel_ppd. Unit: uncore_imc] Perf: uncore_imc_2/event=0x85/ MetricExpr: (unc_m_power_channel_ppd / unc_m_clockticks) * 100. Signed-off-by: Andi Kleen --- tools/perf/util/pmu.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index 4d9632390ab1..2cb463ababb8 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -1096,6 +1096,7 @@ struct sevent { char *topic; char *str; char *pmu; + char *metric_expr; }; static int cmp_sevent(const void *a, const void *b) @@ -1194,6 +1195,7 @@ void print_pmu_events(const char *event_glob, bool name_only, bool quiet_flag, aliases[j].topic = alias->topic; aliases[j].str = alias->str; aliases[j].pmu = pmu->name; + aliases[j].metric_expr = alias->metric_expr; j++; } if (pmu->selectable && @@ -1228,8 +1230,12 @@ void print_pmu_events(const char *event_glob, bool name_only, bool quiet_flag, printf("%*s", 8, "["); wordwrap(aliases[j].desc, 8, columns, 0); printf("]\n"); - if (verbose) - printf("%*s%s/%s/\n", 8, "", aliases[j].pmu, aliases[j].str); + if (verbose) { + printf("%*sPerf: %s/%s/", 8, "", aliases[j].pmu, aliases[j].str); + if (aliases[j].metric_expr) + printf(" MetricExpr: %s", aliases[j].metric_expr); + putchar('\n'); + } } else printf(" %-50s [Kernel PMU event]\n", aliases[j].name); printed++; -- 2.9.3