From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751559AbdBXBZV (ORCPT ); Thu, 23 Feb 2017 20:25:21 -0500 Received: from LGEAMRELO13.lge.com ([156.147.23.53]:60137 "EHLO lgeamrelo13.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751242AbdBXBZU (ORCPT ); Thu, 23 Feb 2017 20:25:20 -0500 X-Original-SENDERIP: 156.147.1.126 X-Original-MAILFROM: minchan@kernel.org X-Original-SENDERIP: 10.177.223.161 X-Original-MAILFROM: minchan@kernel.org Date: Fri, 24 Feb 2017 10:25:16 +0900 From: Minchan Kim To: Shaohua Li Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kernel-team@fb.com, mhocko@suse.com, hughd@google.com, hannes@cmpxchg.org, riel@redhat.com, mgorman@techsingularity.net, akpm@linux-foundation.org Subject: Re: [PATCH V4 1/6] mm: delete unnecessary TTU_* flags Message-ID: <20170224012516.GB9818@bbox> References: <6e99fbb58c019dac280dde73a96586c0eba880d0.1487788131.git.shli@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e99fbb58c019dac280dde73a96586c0eba880d0.1487788131.git.shli@fb.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 22, 2017 at 10:50:39AM -0800, Shaohua Li wrote: > Johannes pointed out TTU_LZFREE is unnecessary. It's true because we > always have the flag set if we want to do an unmap. For cases we don't > do an unmap, the TTU_LZFREE part of code should never run. > > Also the TTU_UNMAP is unnecessary. If no other flags set (for > example, TTU_MIGRATION), an unmap is implied. > > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Hugh Dickins > Cc: Rik van Riel > Cc: Mel Gorman > Cc: Andrew Morton > Suggested-by: Johannes Weiner > Signed-off-by: Shaohua Li Acked-by: Minchan Kim