From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751372AbdBXNdO (ORCPT ); Fri, 24 Feb 2017 08:33:14 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35175 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbdBXNbh (ORCPT ); Fri, 24 Feb 2017 08:31:37 -0500 Date: Fri, 24 Feb 2017 16:31:33 +0300 From: "Kirill A. Shutemov" To: Dave Hansen Cc: linux-kernel@vger.kernel.org, x86@kernel.org, kirill.shutemov@linux.intel.com, shuah@kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] [v2] selftests, x86, pkeys: test with random, unallocated protection keys Message-ID: <20170224133133.GA3796@node.shutemov.name> References: <20170224002339.672BEF68@viggo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170224002339.672BEF68@viggo.jf.intel.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 23, 2017 at 04:23:39PM -0800, Dave Hansen wrote: > > > Changes from v1: > * Also generate random negative numbers for protection key > > -- > From: Dave Hansen > > The kernel pkeys code had a minor bug where it did some large shifts > to an integer which is undefined behavior in C. It didn't cause any > real harm, but it is screwy behavior that the kernel should have > rejected. > > Add a test case for this. > > Signed-off-by: Dave Hansen Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov