* [PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement
@ 2017-02-22 18:23 Georgios Emmanouil
2017-02-22 18:26 ` [PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement Georgios Emmanouil
2017-02-24 16:31 ` [PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement Greg KH
0 siblings, 2 replies; 4+ messages in thread
From: Georgios Emmanouil @ 2017-02-22 18:23 UTC (permalink / raw)
To: arnaud.patard, gregkh, waltfeasel, karniksayli1995,
clifton.a.barnes, shiva
Cc: devel, linux-kernel, trivial
Coding style issue. Added brances to the 'if' statement.
Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
index 6930f7e..c4fdc1c 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -1480,9 +1480,9 @@ static void XGIfb_detect_VB(struct xgifb_video_info *xgifb_info)
cr32 = xgifb_reg_get(XGICR, IND_XGI_SCRATCH_REG_CR32);
- if ((cr32 & SIS_CRT1) && !XGIfb_crt1off)
+ if ((cr32 & SIS_CRT1) && !XGIfb_crt1off) {
XGIfb_crt1off = 0;
- else {
+ } else {
if (cr32 & 0x5F)
XGIfb_crt1off = 1;
else
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement
2017-02-22 18:23 [PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement Georgios Emmanouil
@ 2017-02-22 18:26 ` Georgios Emmanouil
2017-02-24 16:31 ` Greg KH
2017-02-24 16:31 ` [PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement Greg KH
1 sibling, 1 reply; 4+ messages in thread
From: Georgios Emmanouil @ 2017-02-22 18:26 UTC (permalink / raw)
To: arnaud.patard, gregkh, waltfeasel, karniksayli1995,
clifton.a.barnes, shiva
Cc: devel, linux-kernel, trivial
Coding style issue. Added brances to the conditional statement.
Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main_26.c b/drivers/staging/xgifb/XGI_main_26.c
index c4fdc1c..1be0343 100644
--- a/drivers/staging/xgifb/XGI_main_26.c
+++ b/drivers/staging/xgifb/XGI_main_26.c
@@ -1500,18 +1500,19 @@ static void XGIfb_detect_VB(struct xgifb_video_info *xgifb_info)
xgifb_info->display2 = XGIFB_DISP_NONE;
}
- if (XGIfb_tvplug != -1)
+ if (XGIfb_tvplug != -1) {
/* Override with option */
xgifb_info->TV_plug = XGIfb_tvplug;
- else if (cr32 & SIS_VB_HIVISION) {
+ } else if (cr32 & SIS_VB_HIVISION) {
xgifb_info->TV_type = TVMODE_HIVISION;
xgifb_info->TV_plug = TVPLUG_SVIDEO;
- } else if (cr32 & SIS_VB_SVIDEO)
+ } else if (cr32 & SIS_VB_SVIDEO) {
xgifb_info->TV_plug = TVPLUG_SVIDEO;
- else if (cr32 & SIS_VB_COMPOSITE)
+ } else if (cr32 & SIS_VB_COMPOSITE) {
xgifb_info->TV_plug = TVPLUG_COMPOSITE;
- else if (cr32 & SIS_VB_SCART)
+ } else if (cr32 & SIS_VB_SCART) {
xgifb_info->TV_plug = TVPLUG_SCART;
+ }
if (xgifb_info->TV_type == 0) {
temp = xgifb_reg_get(XGICR, 0x38);
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement
2017-02-22 18:23 [PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement Georgios Emmanouil
2017-02-22 18:26 ` [PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement Georgios Emmanouil
@ 2017-02-24 16:31 ` Greg KH
1 sibling, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-02-24 16:31 UTC (permalink / raw)
To: Georgios Emmanouil
Cc: arnaud.patard, waltfeasel, karniksayli1995, clifton.a.barnes,
shiva, devel, trivial, linux-kernel
On Wed, Feb 22, 2017 at 08:23:17PM +0200, Georgios Emmanouil wrote:
> Coding style issue. Added brances to the 'if' statement.
>
> Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
> ---
> drivers/staging/xgifb/XGI_main_26.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Someone sent this same change in just before you did, sorry :(
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement
2017-02-22 18:26 ` [PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement Georgios Emmanouil
@ 2017-02-24 16:31 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2017-02-24 16:31 UTC (permalink / raw)
To: Georgios Emmanouil
Cc: arnaud.patard, waltfeasel, karniksayli1995, clifton.a.barnes,
shiva, devel, trivial, linux-kernel
On Wed, Feb 22, 2017 at 08:26:01PM +0200, Georgios Emmanouil wrote:
> Coding style issue. Added brances to the conditional statement.
>
> Signed-off-by: Georgios Emmanouil <geo.emmnl@gmail.com>
> ---
> drivers/staging/xgifb/XGI_main_26.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
Same here, someone else already did this :(
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-24 16:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-22 18:23 [PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement Georgios Emmanouil
2017-02-22 18:26 ` [PATCH 2/2] Staging: xgifb:XGI_main_26: Added braces to the conditional statement Georgios Emmanouil
2017-02-24 16:31 ` Greg KH
2017-02-24 16:31 ` [PATCH 1/2] Staging: xgifb:XGI_main_26: Added braces to the 'if' statement Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox