From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751351AbdBXQdo (ORCPT ); Fri, 24 Feb 2017 11:33:44 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:32954 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751283AbdBXQdh (ORCPT ); Fri, 24 Feb 2017 11:33:37 -0500 Date: Fri, 24 Feb 2017 17:33:29 +0100 From: Greg Kroah-Hartman To: Maksymilian Piechota Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/2] staging: wlan-ng: move else if statement to a single line Message-ID: <20170224163329.GA5522@kroah.com> References: <7cc81509110c581229367b07e049a959413e9bb2.1487170789.git.maksymilianpiechota@gmail.com> <20170216182724.GA30686@kroah.com> <20170217143300.GA74965@maks-debian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170217143300.GA74965@maks-debian.localdomain> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2017 at 09:33:01AM -0500, Maksymilian Piechota wrote: > On Thu, Feb 16, 2017 at 10:27:24AM -0800, Greg Kroah-Hartman wrote: > > On Wed, Feb 15, 2017 at 10:11:00AM -0500, Maksymilian Piechota wrote: > > > move else if statement to a single line > > > > > > Signed-off-by: Maksymilian Piechota > > > --- > > > drivers/staging/wlan-ng/prism2mgmt.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c > > > index 16fb2d3..a45ff00 100644 > > > --- a/drivers/staging/wlan-ng/prism2mgmt.c > > > +++ b/drivers/staging/wlan-ng/prism2mgmt.c > > > @@ -1307,8 +1307,7 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) > > > && (msg->prismheader.data == P80211ENUM_truth_true)) { > > > hw->sniffhdr = 0; > > > wlandev->netdev->type = ARPHRD_IEEE80211_PRISM; > > > - } else > > > - if ((msg->wlanheader.status == > > > + } else if ((msg->wlanheader.status == > > > P80211ENUM_msgitem_status_data_ok) > > > && (msg->wlanheader.data == P80211ENUM_truth_true)) { > > > hw->sniffhdr = 1; > > > > This patch does not apply to my tree at all :( > > > > Please rebase and resend the series. > > > > thanks, > > > > greg k-h > > ok, I've got newest sources and this change is already applied. So what > are the next steps suggested? Suggested for what? > I've heard there is a possibility to obtain mentor, right? Mentor for what? confused, greg k-h