From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751275AbdBXRHt (ORCPT ); Fri, 24 Feb 2017 12:07:49 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:36044 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751314AbdBXRH2 (ORCPT ); Fri, 24 Feb 2017 12:07:28 -0500 Date: Fri, 24 Feb 2017 18:07:21 +0100 From: Greg KH To: Chetan Sethi Cc: devel@driverdev.osuosl.org, punitvara@gmail.com, wsa@the-dreams.de, mattkilgore12@gmail.com, linux-kernel@vger.kernel.org, weiyongjun1@huawei.com, shiva@exdev.nl, bhumirks@gmail.com Subject: Re: [PATCH v3 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Message-ID: <20170224170721.GA7142@kroah.com> References: <1487324779-28998-1-git-send-email-cpsethi369@gmail.com> <1487324859-29056-1-git-send-email-cpsethi369@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487324859-29056-1-git-send-email-cpsethi369@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 17, 2017 at 06:47:39PM +0900, Chetan Sethi wrote: > This is 02nd patch to file ks_wlan.h file fixing error of enclosing > complex macro value in parentheses No need to have the "This is the XXX patch..." in the changelog text, you don't see that in any other commit logs, right? > > Signed-off-by: Chetan Sethi > --- > v2: > - split multiple changes across different patches > v3: > - mentioned patch revision in subject > - incorporated review comment of correct indentation for do statement > > drivers/staging/ks7010/ks_wlan.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h > index 668202d..33d6b28 100644 > --- a/drivers/staging/ks7010/ks_wlan.h > +++ b/drivers/staging/ks7010/ks_wlan.h > @@ -36,8 +36,10 @@ > > #ifdef KS_WLAN_DEBUG > #define DPRINTK(n, fmt, args...) \ > - if (KS_WLAN_DEBUG > (n)) \ > - printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) > + do { \ Always run checkpatch on your patches so you don't get a grumpy maintainer telling you to run your patches through checkpatch! Please fix up all 3 of these and resend. thanks, greg k-h