From: Greg KH <gregkh@linuxfoundation.org>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: ks7010: Block comments use * on subsequent lines
Date: Fri, 24 Feb 2017 18:08:18 +0100 [thread overview]
Message-ID: <20170224170818.GA7219@kroah.com> (raw)
In-Reply-To: <20170218153233.GA6466@arushi-HP-Pavilion-Notebook>
On Sat, Feb 18, 2017 at 09:02:33PM +0530, Arushi Singhal wrote:
> Some of the block comments styles are not encouraged:
> for example:
> /*
> block comment without introductory *
> */
> and
> /*
> * block comment with line terminating */
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/ks7010/ks7010_sdio.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index a604c83c957e..2c263f98bdbb 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -495,8 +495,10 @@ static void ks7010_rw_function(struct work_struct *work)
> /* wiat after WAKEUP */
> while (time_after(priv->last_wakeup + ((30 * HZ) / 1000), jiffies)) {
> DPRINTK(4, "wait after WAKEUP\n");
> -/* queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
> - (priv->last_wakeup + ((30*HZ)/1000) - jiffies));*/
> +/*
> + * queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
> + * (priv->last_wakeup + ((30*HZ)/1000) - jiffies));
> + */
Why did you loose the correct indentation here when you commented this
out?
If it's commented out, why not just delete the code instead?
thanks,
greg k-h
prev parent reply other threads:[~2017-02-24 17:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 15:32 [PATCH] staging: ks7010: Block comments use * on subsequent lines Arushi Singhal
2017-02-24 17:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170224170818.GA7219@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox