From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751282AbdBXRId (ORCPT ); Fri, 24 Feb 2017 12:08:33 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:36052 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751461AbdBXRI0 (ORCPT ); Fri, 24 Feb 2017 12:08:26 -0500 Date: Fri, 24 Feb 2017 18:08:18 +0100 From: Greg KH To: Arushi Singhal Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Subject: Re: [PATCH] staging: ks7010: Block comments use * on subsequent lines Message-ID: <20170224170818.GA7219@kroah.com> References: <20170218153233.GA6466@arushi-HP-Pavilion-Notebook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170218153233.GA6466@arushi-HP-Pavilion-Notebook> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 18, 2017 at 09:02:33PM +0530, Arushi Singhal wrote: > Some of the block comments styles are not encouraged: > for example: > /* > block comment without introductory * > */ > and > /* > * block comment with line terminating */ > > Signed-off-by: Arushi Singhal > --- > drivers/staging/ks7010/ks7010_sdio.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c > index a604c83c957e..2c263f98bdbb 100644 > --- a/drivers/staging/ks7010/ks7010_sdio.c > +++ b/drivers/staging/ks7010/ks7010_sdio.c > @@ -495,8 +495,10 @@ static void ks7010_rw_function(struct work_struct *work) > /* wiat after WAKEUP */ > while (time_after(priv->last_wakeup + ((30 * HZ) / 1000), jiffies)) { > DPRINTK(4, "wait after WAKEUP\n"); > -/* queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq, > - (priv->last_wakeup + ((30*HZ)/1000) - jiffies));*/ > +/* > + * queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq, > + * (priv->last_wakeup + ((30*HZ)/1000) - jiffies)); > + */ Why did you loose the correct indentation here when you commented this out? If it's commented out, why not just delete the code instead? thanks, greg k-h