Re: [PATCH] staging/ks7010: formatting updates.

Joe Perches
2017-02-21T18:48:38Z

On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote:
> * Geert Uytterhoeven <geert@linux-m68k.org> [2017-02-21 15:22:10 +0100]:
>
> > The first declaration fit nicely on a single line.
> > The second one indeed has a few spaces instead of TABs in the
> > continuation line. But that can be fixed easily, without moving the
> > first parameter to a continuation line.
>
> What would the proposed fix be? A combination of spaces and hard-tabs? I
> don't see checkpatch complaining about it, so that could work too.

Maximal initial tabs, followed by required spaces to align
to open parenthesis

So from:

int ks_wlan_setup_parameter(struct ks_wlan_private *priv,
unsigned int commit_flag);

(2 tabs followed by 13 spaces)

to:

int ks_wlan_setup_parameter(struct ks_wlan_private *priv,
unsigned int commit_flag);

(3 tabs followed by 4 spaces)