Re: [PATCH] staging/ks7010: formatting updates.

Geert Uytterhoeven
2017-02-21T07:59:29Z

Hi Matthew,

On Tue, Feb 21, 2017 at 5:20 AM, Matthew Giassa <matthew@giassa.net> wrote:
> Please pardon the earlier e-mail which was missing the changelog text.

This line should be between the "---" and the diffstat below.

> Some additional style changes to appease checkpatch.

Which additional style changes?

> ---
> drivers/staging/ks7010/ks_wlan_ioctl.h | 80 +++++++++++++++++-----------------
> 1 file changed, 41 insertions(+), 39 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
> index 84554b6..00eec18 100644
> --- a/drivers/staging/ks7010/ks_wlan_ioctl.h
> +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h

> #include "ks_wlan.h"
> #include <linux/netdevice.h>
>
> -int ks_wlan_read_config_file(struct ks_wlan_private *priv);
> -int ks_wlan_setup_parameter(struct ks_wlan_private *priv,
> - unsigned int commit_flag);
> +int ks_wlan_read_config_file(
> + struct ks_wlan_private *priv);
> +int ks_wlan_setup_parameter(
> + struct ks_wlan_private *priv,
> + unsigned int commit_flag);

Really?
If checkpatch complained about the above, you should file a bug report
against checkpatch.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds