public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Pranay Kr. Srivastava" <pranjas@gmail.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
	samuel.thibault@ens-lyon.org, sfr@canb.auug.org.au,
	speakup@linux-speakup.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH-SPEAKUP 1/2] return same error value from spk_set_key_info
Date: Fri, 24 Feb 2017 18:32:53 +0100	[thread overview]
Message-ID: <20170224173253.GA14908@kroah.com> (raw)
In-Reply-To: <20170222072027.4257-2-pranjas@gmail.com>

On Wed, Feb 22, 2017 at 12:50:26PM +0530, Pranay Kr. Srivastava wrote:
> This patch makes spk_set_key_info return -EINVAL
> in case of failure instead of returning 4 different
> values for the type of error that occurred.
> 
> Print the offending values instead as debug message.
> 
> Signed-off-by: Pranay Kr. Srivastava <pranjas@gmail.com>
> ---
>  drivers/staging/speakup/main.c | 27 +++++++++++++++++++--------
>  1 file changed, 19 insertions(+), 8 deletions(-)

Please fix the build errors and resend this series.

thanks,

greg k-h

  parent reply	other threads:[~2017-02-24 17:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22  7:20 Pranay Kr. Srivastava
2017-02-22  7:20 ` [PATCH-SPEAKUP 1/2] return same error value from spk_set_key_info Pranay Kr. Srivastava
2017-02-22 10:26   ` Samuel Thibault
2017-02-24 15:32   ` kbuild test robot
2017-02-24 17:32   ` Greg KH [this message]
2017-02-28 12:13   ` kbuild test robot
2017-02-22  7:20 ` [PATCH-SPEAKUP 2/2] remove unecessary initial allocation of vc Pranay Kr. Srivastava
2017-02-22 10:27   ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170224173253.GA14908@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=chris@the-brannons.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=kirk@reisers.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pranjas@gmail.com \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=sfr@canb.auug.org.au \
    --cc=speakup@linux-speakup.org \
    --cc=w.d.hubbs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox