From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751420AbdBXRdH (ORCPT ); Fri, 24 Feb 2017 12:33:07 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:38056 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbdBXRdB (ORCPT ); Fri, 24 Feb 2017 12:33:01 -0500 Date: Fri, 24 Feb 2017 18:32:53 +0100 From: Greg KH To: "Pranay Kr. Srivastava" Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca, samuel.thibault@ens-lyon.org, sfr@canb.auug.org.au, speakup@linux-speakup.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH-SPEAKUP 1/2] return same error value from spk_set_key_info Message-ID: <20170224173253.GA14908@kroah.com> References: <20170222072027.4257-1-pranjas@gmail.com> <20170222072027.4257-2-pranjas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170222072027.4257-2-pranjas@gmail.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 22, 2017 at 12:50:26PM +0530, Pranay Kr. Srivastava wrote: > This patch makes spk_set_key_info return -EINVAL > in case of failure instead of returning 4 different > values for the type of error that occurred. > > Print the offending values instead as debug message. > > Signed-off-by: Pranay Kr. Srivastava > --- > drivers/staging/speakup/main.c | 27 +++++++++++++++++++-------- > 1 file changed, 19 insertions(+), 8 deletions(-) Please fix the build errors and resend this series. thanks, greg k-h