From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751318AbdBXRh6 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Feb 2017 12:37:58 -0500
Received: from mail.linuxfoundation.org ([140.211.169.12]:38180 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751121AbdBXRhw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Feb 2017 12:37:52 -0500
Date: Fri, 24 Feb 2017 18:37:40 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: "Pranay Kr. Srivastava" <pranjas@gmail.com>
Cc: w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca,
        samuel.thibault@ens-lyon.org, sfr@canb.auug.org.au,
        speakup@linux-speakup.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove unnecessary initial allocation of vc
Message-ID: <20170224173740.GA2265@kroah.com>
References: <20170221140332.60200-1-pranjas@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170221140332.60200-1-pranjas@gmail.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 21, 2017 at 07:33:32PM +0530, Pranay Kr. Srivastava wrote:
> This patch removes the unnecessary allocation of
> current foreground vc during initialization.
> 
> Also change the prototype of speakup_allocate to take
> extra argument of gfp_* flags. Thus not requiring
> GFP_ATOMIC during initialization.

That's two different things, please do this in two different patches.

And always say what driver/subsystem you are patching in your subject
line, like other patches for the same driver.

Please fix up and resend.

thanks,

greg k-h