From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751442AbdBXRmF (ORCPT ); Fri, 24 Feb 2017 12:42:05 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:38396 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbdBXRl5 (ORCPT ); Fri, 24 Feb 2017 12:41:57 -0500 Date: Fri, 24 Feb 2017 18:41:50 +0100 From: Greg KH To: Joe Perches Cc: Yamanappagouda Patil , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, driverdev-devel@linuxdriverproject.org Subject: Re: [PATCH] staging: vc04_services: Fixed "space prohibited after that open/close parenthesis" erros. Message-ID: <20170224174150.GA10223@kroah.com> References: <1487860253-6840-1-git-send-email-goudapatilk@gmail.com> <1487873755.14159.43.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487873755.14159.43.camel@perches.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 23, 2017 at 10:15:55AM -0800, Joe Perches wrote: > On Thu, 2017-02-23 at 20:00 +0530, Yamanappagouda Patil wrote: > > Fixed checkpath.pl erros "space prohibited after that open/close parenthesis" in vchiq_version.c file. > > > > Signed-off-by: Yamanappagouda Patil > > --- > > .../vc04_services/interface/vchiq_arm/vchiq_version.c | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_version.c > [] > > @@ -33,27 +33,27 @@ > > #include "vchiq_build_info.h" > > #include > > > > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_hostname, "dc4-arm-01" ); > > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_version, "9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)" ); > > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_time, __TIME__ ); > > -VC_DEBUG_DECLARE_STRING_VAR( vchiq_build_date, __DATE__ ); > > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_hostname, "dc4-arm-01"); > > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_version, "9245b4c35b99b3870e1f7dc598c5692b3c66a6f0 (tainted)"); > > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_time, __TIME__); > > +VC_DEBUG_DECLARE_STRING_VAR(vchiq_build_date, __DATE__); > > Uses of __TIME__ and __DATE__ make it > impossible to have repeatable builds. > > Are these __TIME__ and __DATE__ uses > really useful and necessary? No, they need to be removed, but not in this patch :) thanks, greg k-h