From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750995AbdBXTG0 (ORCPT ); Fri, 24 Feb 2017 14:06:26 -0500 Received: from mail-cys01nam02on0076.outbound.protection.outlook.com ([104.47.37.76]:14944 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751221AbdBXTGR (ORCPT ); Fri, 24 Feb 2017 14:06:17 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=syeh@vmware.com; Date: Fri, 24 Feb 2017 11:06:05 -0800 From: Sinclair Yeh To: =?iso-8859-1?B?2Hl2aW5kIEEu?= Holm CC: , VMware Graphics , Thomas Hellstrom , David Airlie , Subject: Re: [PATCH v2] Revert "drm/vmwgfx: Replace numeric parameter like 0444 with macro" Message-ID: <20170224190603.GA24809@syeh-m01.local> References: <20170204181727.15426-1-sunny@sunbase.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170204181727.15426-1-sunny@sunbase.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [206.169.187.210] X-ClientProxiedBy: SN1PR19CA0005.namprd19.prod.outlook.com (10.163.220.15) To CY4PR05MB3288.namprd05.prod.outlook.com (10.171.247.160) X-MS-Office365-Filtering-Correlation-Id: e72ab467-d9a8-4ed3-d8eb-08d45ce834a5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR05MB3288; X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3288;3:8Op51gZmULwgGbYV7pDjAk0aI3Z4H2letxNMO2GJ7krlsKSCkir6UMiffRko0ifx+9sKvlbPUuOY02kYv/b9x2xH+PD8Z+BvnN7XPVFz5iMwo7f2tgKw3pFH7U7NjOuU+Y3cXpuJ77jdo5Ps32AJ3yLOHeqgtb0ZdF36goSubH5VNiwUbVtrCBBAXhsdLw5wSORlYKLKLvQp/4/MTVaZJtUrOLpk87NCxymhLFmksoehNv8p66wUv1BlvYbpkZ9rMrTCWM6REVGz3EQyFqyZTA==;25:T5rjsFTT2DLONyP6n7Y+iCaAHJUiHEdUROzar2fO+6nnHQ2UisBb2SyqM3xu22JOIjF7o5/BF85lG0fLm/TpSLv+PB3ErsosdkTMQX4iNCBmy2aoHE55ZczRPub4Sivfif7l2RoW6VlDHXaNdL3zovN2kSj5aUqBkt9R/vsbfYJ4ZcgtzHLAOMgKmCf5TdBsrCbXCe6hZXp77dRAmuHm6Y2SkZAKPgpcZiHXk0QMh5eaSIKYdtH0mKfriFhFcpsy/+ntAqpgAsdTM5Naat3se3YaST6SvPVizGPDOHo8uPaqOBS1RYonuflUQooDscD5+AchkFb3hYEFqIeW7XumbfJ6wBdohYtdVcSL4WCTa7SvXFrtIBQwXjTwPiehMNg3R/5TfNPpcgYykRetfF9Jtlf7dhdqnQJsUzHaYl7m02XD8m2M+wYVK59b5SqSgx/5ZFb2ECvBfAwntZwwaa/+5g== X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3288;31:mbAX4wDfTgliQnYMhR4sCTjSayZX+lsNGsjbfuhjiR+0L0bXcKqisFSyAzIKEw42+cUWHl48JrXpSeI9evq/InVMFpbQBSfrhfDZSatIWm5NsS8GeweI6fk1DpZ4FGCWydpiyyfFH50/kthJqzXYw7k4bK81L6CCgqfJ/w23B6wN05n4oHAoYSSYVgibkYA2D6l8Od2wHS7eqqQGmj591ZIoOL9olxR56ug/fzl3xgo=;20:uIFuuNDM55+PnCaq0SfxSr1WXLBv2aljBMxI+xWn5tcZi7WyQxO5MHpbDOvcWtwDJlaNALiL4SK+4oWXLbxIXV+3TCWUAiUriZj9pYBU4+ff0oB5qaWL/kIgymLvm8RuNv1s6L5CR6phTvdWmrxnx3eErSrtnHJ3hIWGWxst7avtIqax2BT6l8qX4su2IXCO84eJDKg3et1df+oNMHBRPeM91zfdKnwTj220c/SZtMKnJXek8f/gNY7BxWWLnqjQ7V6w8mJKT3dAw8mIvbs1jTakzHVEy2j6gsv3ibpnxGj3ZwjnoyPQBC/1WaDgZZ6+HeWn1bnof/VQn4920edMG4aqmwhn4Eles84GC8bxjzk0E78fN+fwVRcMQP06JI08e1zA6mJU5ui6NnXD6ai4ymbKEjg7QuQlEXxgyqCVoCFNjvPfxzECDgzEPHakpxMwyLEV0Ali6uHk9ZXq+JJIm8M4EbCZj4cKsXHIwRwqoveZ1YZ4qKVuX72dbGXHrtWE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(100405760836317); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123555025)(20161123562025)(20161123558025)(20161123564025)(20161123560025)(6072148);SRVR:CY4PR05MB3288;BCL:0;PCL:0;RULEID:;SRVR:CY4PR05MB3288; X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3288;4:TQ/0k5UMNFVMSDw4HWkc6T7hK2UYUIa98NR8NmrUM75v/L0FeO+GpFWxvuIGVuz3cyFJSrw1NY1TIBGc7anHUbMqpKVs/hVwTxxWqmernoa3ofBs4pvn2m+DqESRSmmISOGiwCfTEvMrqzneVSPm9P3eWOdYGZVvMDLsueorda4dB9PPOemSBvRv60Ckx3WbRN9NFVDADO513FHFqqFq+XN9c+KhMnfMUh39MCPI4FhVs1Yu35NvylK08ZoYZOKsNGe68bTsrNOuYT7rXvw2BEoHgiRZvLfq9xQWDMxVH292LELTiEKubBGMJFi7aH/pZsPkmgbzRXK/nMDbHXZVwo8Z+tWhJ4XDqXnFF+1eK7dudwA+mBNa8frlyW98thLcir1RPn7HRanefZ52cfAOXL5pplCsIpIDV/rZJ6+pR78MAJ5TLXs2+8epQ2s+f7cXz2Gl4wOlj5aD4usDNmjNsrFUMYwyimbSGqqr3eF/IN/WFgbVcS9FBPs9RAgJpsb3fTbDIrUr3ZVIJhjz3ZlElivSRWFcY0NXtFakKgGGGuno4IL5Cou1wyrtDcyehqAjH7gI187cTRXPOM+3KyN0BJdcTf/tpaTV6jjhyj7hAzZb+cd0nl1n6d36k6uoNsUFGNrR3N9ed299qn88zun/ZNjVKlX98SVMMIZIMn/bF26bl2SwqxV/t6q3TUgg5gyW X-Forefront-PRVS: 0228DDDDD7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(24454002)(199003)(189002)(377424004)(42186005)(54906002)(6666003)(106356001)(229853002)(50466002)(7736002)(305945005)(5660300001)(9686003)(8676002)(98436002)(33656002)(6506006)(55016002)(50986999)(6116002)(105586002)(2950100002)(101416001)(76176999)(54356999)(6916009)(25786008)(23756003)(83506001)(66066001)(38730400002)(2906002)(1076002)(189998001)(92566002)(4326007)(86362001)(68736007)(47776003)(3846002)(4001350100001)(6246003)(97736004)(81156014)(2870700001)(53936002)(81166006)(110136004)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR05MB3288;H:syeh-m01.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CY4PR05MB3288;23:RfDj4wD8qNZtp66nJ1QYzRnvJ4a9OPtoHmzHtV1?= =?iso-8859-1?Q?peJNpKOF2BaI8/TBj6TByMX+m34X+zHkp5JtULeuU4NnPLJYb5eyjE6ECl?= =?iso-8859-1?Q?zRYtw+/tJrRU+arY6rmNdg7jmN7N/s+wUctPjb2uUOmzkxMfU4Gv7WgTuN?= =?iso-8859-1?Q?Ay1e0amTJTftIG1NaXdNATSUt5YUDbK8+lq0TVm8Ogob6K0WUer/hzzgxh?= =?iso-8859-1?Q?o/Than3s1pJCngsTzI5W5a7EtkvU5Qt1yjmWwl6CrWmuGSU54vsE8bNMam?= =?iso-8859-1?Q?DHtz3Qk42BsNCF0K4t9FoYTrImrBscvfiZKn7MfoWHUHCuXKEK1GAJ/6XN?= =?iso-8859-1?Q?VaB7va+1cGdgrvwzJj4aRb/G1jaSIQJpP3RmFYcCavlhIJEs++p5279Zu4?= =?iso-8859-1?Q?bFjPAduo4amWm0B52fhVaaxVhKZxerWKl5xzECgk8seX8rvH5UFGHbZ+z3?= =?iso-8859-1?Q?9myXsJN97IgVyeT8x2rWhGr2lAylCJOU6RS+SB3vAwAlMDJfHTbPoeHdLB?= =?iso-8859-1?Q?2yPzcUNXPoSUyuJHW/csQqK69QcWQePFtbRHOwK+F9xvdHMjj7gcpnN205?= =?iso-8859-1?Q?5YOA37oUzROzklOKHNAa5JvWlP0f3L+yFLUqxLvBzw41Oyb+1eqCFWR2LW?= =?iso-8859-1?Q?sIJhlEz3Xnp+oMHSCahaEDL6bnK+Yy46ghhuEUOHnqcdaPkbHaEmisDUIC?= =?iso-8859-1?Q?xe0NBRdaeh+y5Hclwot6eJdf0nvMMbZsD+8tzM/dHsIRbIWdjIPrhcpoWQ?= =?iso-8859-1?Q?Aqvz5I/+uWBcJHIR7srNTHPaTU+Y09LKK+W+5ZEzRBvPXtShVDe8ZI6Ter?= =?iso-8859-1?Q?08C5+HcIzy+g1uOowFRumHfKUyL5dZqHUq1ZM+mWCwmNwVvNveKl/Vxs7n?= =?iso-8859-1?Q?1nh3zMEyCu+y7DY0ZDrso+YVTsn2yzSs3Ov+U7CQC+tWbVwIaLbRmpNRqC?= =?iso-8859-1?Q?Xc7VfyMiMYx2cjKjMkzY/4XNyMAME5h7yqWZErBopkYl9iXCFa0d5s8ukY?= =?iso-8859-1?Q?T0Is2bGTAG04f34gaW9L4VeqI07Ue6PrZ8nQF7oir41W33fj11UDSnWBge?= =?iso-8859-1?Q?/RWPu6qlW6L3wdhwdUMboEeaYPp1T404GxFWrcCwPtIznHxcjFX5QzQNJ4?= =?iso-8859-1?Q?aG+JawzvQgMwufKxXnYJBkJQ/A1MOj+LaetbrWH0EF10EtEkVgtn3IfQAQ?= =?iso-8859-1?Q?QBek8jvCNUr761e3C8hFcwlAUxdcikCE23vQTqV9ycPsJOjm3giyYQGKMH?= =?iso-8859-1?Q?zO1vXn6hpi+bB+lKw3RB00J1gMJQPnfPC+QCussXVsU9/SnGRuV6Ue/Ef3?= =?iso-8859-1?Q?0YFeumLmfNUmSo7z4Lxg0n4DxCLKzmkDITFeH7kI9hEKQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3288;6:NC6LRjzj6eZbvzFWE+s3CxKWxH407z+P1yJjYVNCROz/OsjlRtFL/WSzLX8FUiPuHSVrvF5aoncJHnyaayKzIJbY9BYHWwPsihW9gBkZzfIo/ksHqbkj4AdZkbjtNUf63+3ekgFMdArf4DzPaRcxSDPLeHlqS+SIc2ZEgpONag90PmrsL1f6P/bSuZU/7JyofoAv1pDpA+jcVbKTT2xlyr87S9mhIhc93kaC19MWjedwZcXfHsJjCHGiQ1vb1UsrKoVCt07TveyD/yuuNoevdC9Y12t2vxIbzpVGdN/Axy1ErotSysTQa+YBzsmXRKtJQ5fdNehBVfNdnl6CHU372dU1sUuaehKfOreBqYWG9NW97KUeYGKBiAWknfdMjijC72robxBLyNVeP6fo3YEx0g==;5:GEKHcCYToMqlDU5CpwfCEhY7p+SCXOzLt2FktMVGAjchZpLabx828rB0F02MVQR7NT8ybno2MtYtz2aZHeiYe3CtPICGkmnZ73JpBWfMHYzvkAXT/v3Vfn4EbFisb7xspIt/15Ytq1kBgrCSkUOEjw==;24:UFUMuGnUfXXLTmeMiw6ezdLb4ZA1cVk2FQjz+K7jNZXDgoDDfliMlzJ1jUUhW6ZVPgZ9ThdpTDWFTzogb6inm/w51IxUCAiDInHghm/ynSI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3288;7:MUKIxislNEWJyEfdNLUBMfnJsVMYntZeaZsqRGuHFwn5j5tDVINJcy79ihYKEjRAnuP6fpVSlYCR6ltzS0UCSmFERYaHYTwi53fuelNeUHDoirBWN2GX3SQ7O2NRK7KYKyXHTh5jCyFx/YzHcURXRCOCg9OrkO3qL73eguXYlPgnae8I6ZDbYphg63JtsZwKVnhYdDIqmXJsWwErw+3CmkDotVlNAC/7230guV+LAf4dana9l5dgquweRdQ6Hb2fhQ+P1xfeNaao+DXNGDBI5mVXInfDHuGreBtmWWbuUbXJkQ0nmSJhpUkD6CTNtDV8lo9CzxaCbCTJmMJv7RS3AQ==;20:nHItweYtpV7F15Y+Yd3LmocHAr9XaSEjSy01e5ywudKO/wpq0G47TAF9nEEGWwvrqobqklWuXVv3rQCIdV/9p4ycasbGfVmAeTldyYFxblTnwgnigbGdWto2hhGoQdQ4sPb0mUMAQNxwMqQejuos6sUV4GRoGPSQzREqVDnd5F8= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2017 19:06:14.5909 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB3288 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Oyvind, Thanks for looking at this. At this moment, I don't really see a benefit one way or anther, so I am going to stick with the macro version for now, changing the one remaining module_param_named() you mentioned to using the macros to keep things consistent. If one day we have a paramter with a long ORing of the macros, then we can revisit this decision. Sinclair On Sat, Feb 04, 2017 at 07:17:27PM +0100, Øyvind A. Holm wrote: > This reverts commit 2d8e60e8b0742b7a5cddc806fe38bb81ee876c33. > > The commit belongs to the series of 1285 patches sent to LKML on > 2016-08-02, it changes the representation of file permissions from the > octal value "0600" to "S_IRUSR | S_IWUSR". > > The general consensus was that the changes does not increase > readability, quite the opposite; 0600 is easier to parse mentally than > S_IRUSR | S_IWUSR. > > It also causes argument inconsistency, due to commit 04319d89fbec > ("drm/vmwgfx: Add an option to change assumed FB bpp") that added > another call to module_param_named() where the permissions are written > as 0600. > > Signed-off-by: Øyvind A. Holm > --- > This is a resend of the patch originally sent on 2017-01-16. The only > difference from v1 is an improved commit message with some more details. > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > index 18061a4bc2f2..e8ae3dc476d1 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > @@ -241,15 +241,15 @@ static int vmwgfx_pm_notifier(struct notifier_block *nb, unsigned long val, > void *ptr); > > MODULE_PARM_DESC(enable_fbdev, "Enable vmwgfx fbdev"); > -module_param_named(enable_fbdev, enable_fbdev, int, S_IRUSR | S_IWUSR); > +module_param_named(enable_fbdev, enable_fbdev, int, 0600); > MODULE_PARM_DESC(force_dma_api, "Force using the DMA API for TTM pages"); > -module_param_named(force_dma_api, vmw_force_iommu, int, S_IRUSR | S_IWUSR); > +module_param_named(force_dma_api, vmw_force_iommu, int, 0600); > MODULE_PARM_DESC(restrict_iommu, "Try to limit IOMMU usage for TTM pages"); > -module_param_named(restrict_iommu, vmw_restrict_iommu, int, S_IRUSR | S_IWUSR); > +module_param_named(restrict_iommu, vmw_restrict_iommu, int, 0600); > MODULE_PARM_DESC(force_coherent, "Force coherent TTM pages"); > -module_param_named(force_coherent, vmw_force_coherent, int, S_IRUSR | S_IWUSR); > +module_param_named(force_coherent, vmw_force_coherent, int, 0600); > MODULE_PARM_DESC(restrict_dma_mask, "Restrict DMA mask to 44 bits with IOMMU"); > -module_param_named(restrict_dma_mask, vmw_restrict_dma_mask, int, S_IRUSR | S_IWUSR); > +module_param_named(restrict_dma_mask, vmw_restrict_dma_mask, int, 0600); > MODULE_PARM_DESC(assume_16bpp, "Assume 16-bpp when filtering modes"); > module_param_named(assume_16bpp, vmw_assume_16bpp, int, 0600); > > -- > 2.12.0.rc0 >