From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751356AbdBXTdr (ORCPT ); Fri, 24 Feb 2017 14:33:47 -0500 Received: from mail-by2nam03on0041.outbound.protection.outlook.com ([104.47.42.41]:24178 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751265AbdBXTdi (ORCPT ); Fri, 24 Feb 2017 14:33:38 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=syeh@vmware.com; Date: Fri, 24 Feb 2017 11:33:12 -0800 From: Sinclair Yeh To: =?iso-8859-1?B?2Hl2aW5kIEEu?= Holm CC: , VMware Graphics , Thomas Hellstrom , David Airlie , Subject: Re: [PATCH v2] Revert "drm/vmwgfx: Replace numeric parameter like 0444 with macro" Message-ID: <20170224193312.GA36270@ubuntu> References: <20170204181727.15426-1-sunny@sunbase.org> <20170224190603.GA24809@syeh-m01.local> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170224190603.GA24809@syeh-m01.local> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [206.169.187.210] X-ClientProxiedBy: DM5PR19CA0016.namprd19.prod.outlook.com (10.175.226.154) To CY4PR05MB3285.namprd05.prod.outlook.com (10.171.247.157) X-MS-Office365-Filtering-Correlation-Id: 86db9c3d-6d10-4aae-f99d-08d45cebfe3a X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR05MB3285; X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3285;3:lAmtWg5WLY7gOyjtPSE1E0QzV3Drk00+jP8ryv+E7C+wRuH8W2FLyxyJ9JDtrdxgP7vrch2WCBKPco4YQh7vkDqQkhcVxBmuk8K/IY9BNMBvjYSSpX/CdyKRPTy0nw+TRjatkYjfst68x3+wO1GiwKVgGmHUTr35jjZ4zx3Dxap0QezujX/RVkZt+OI4blHGPsqoUpZxVu+Zkn0RekzqLO56X/9+GZXgoJhKScAeX4JPnrMEt1qelqL+rv8nEFnyWyNkcz+boZixX0PU9/V+6A==;25:kKe+5OEew+b3zbftS6EuCBO6LcI9zBEQffAKP+zO+XLh8jeJ48WQKw6qBiGqe3HqOCZ6UHWnntyag01IpLfULDXy9rOkk121pHk0nmTLB8mglW4zIdERx0JBBCWtvZvOuehHY/Mq6nKc8RM4gR5qEjL24nDOW08qQ+yLksXiR8NYHwMGm0g7Iq2BNjrlo+QA1uDGHQyx7yOaHeB/zi1vrg+8bTMbjEbWWLfaszvDlFfPdOktpxs5k46Rk1/tVrhc24MwcCoccO9iQ1zLsNhjxkLAN4f5mDcrrQp0Y3rEkNlKks5W+nEeENtCj84FczHO0Dji0Z24i6o1w3fhQolnIp+MNDcGaVkDLM+9TjRlL/AVhjwzlCFqzG7MPpyPhktrZaORoG5ZDM9jiA4wZnV4kHk2uVrWPswjcVaP/Tt5U474ekpweUWQWkHuzH95qLAqKzcSqm0oz+YC5cO+79pS2A== X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3285;31:S431mVnNr2rG6ckjvKWGvKh5FFh1BlYbtsY351iY72z9M4G4VyKLe76kSlx4mRCpfYDz/aC6k+QlC53Na2bcV2kI+WwbS70HIvOx0T2AP3rRwwyj5FwnZb7V5dyWuCuUFM2UOU5Tbh82yAJS9MYB6lwD33w3QVbfx9A9TLQRL8fQT1MZ3rcFkMcxso7N7BlD4rF6NEOhJcBlHRyRg3OOzOy8pdaAvAFVqd29cw+aQew=;20:jE9aaEiV6Wrn9u11Musv0bAWGV3Lsa2HYK4kfGw/psiPSJ9ipuKxIeQc0itz1N9TvWa4XJvc5fo+oITkXXSPvFp3X2wVgQj18Br+rECvIctBJAW6NED6a/Nezsg8e4etf0Fv8nE/woHgk80wzGa2lTlbSSe+6zGdnLu2CfghwAaMdX0cPywQpERNCX7/1tzN3Rd56QiiTBEVoxLhYnrNOxddP54QAUZmN1FDLTGxSegF/lmks7W2UlDXO0F3Cd/fra6vO75SMnEFXLa6ngPhwzCc+IDmwPG40rlzFI8PWyABmutyw9gS6nTJ+R8lHLTTNlMGZGM3RKfva4fSx9bFjW/B3sHXUxQtNd/0Pyg5C7ynBDKfM46dg4XFEEZU6z92sQBxVIprYbE987JA5Uupz5Yb0X4Fmp5v6n+VKLq5tH2G5De4R4dSAKMHgRFmLMLmniRZR316PV/X+YRG5fqBCGH4tLZmTb380nAATVT8ViYkMRcq004pojJavv4O0vK+ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(788757137089)(100405760836317); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6041248)(20161123558025)(20161123564025)(20161123562025)(20161123555025)(20161123560025)(6072148);SRVR:CY4PR05MB3285;BCL:0;PCL:0;RULEID:;SRVR:CY4PR05MB3285; X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3285;4:3jOrrMgcuBRnpRK6j1V8AJ3MkVDbzaTAYszQGeVxE0YEpMijgdy2R92nluGr8CT6JYpOleNpgVODwaOLGNG3pvcc/n2Hocv+lMpAZHLwhWkBHO0zaEbf6YF5s6NauQODb8OkzJHE21CmlEJYC7M2zl/+P/lwaEQBFUc/eEYpocqkhbiVHuSVyobot7Py/TgafEAeor5VDnzUbJtB2e+Bypf6xkABqbxSryagBQAdZKVbycjaAQ9G6jtQG8eOIe4CcLtKaLXtAuvuTUv5upyxfJsQiBtBOkbvcnXbOf6J7QX3LGCt9x7MmmghlWZ+M7iYSAmLNE4pGOr3KJskhnf+U4T/3t+blxHxJnrUBD2vj5MKaOtO52iRuxgZCSE6GttXf5e1PEsuOJyqSXSquH/QQOmprw7RUrzF+F8rGEiLMfbfJp5UYd3m6huZRDFqwOycTkFhPZ5VuaHe1FlDofvMmdI/Ni1u6P3gu/wKGomKGSK+sNj+AlIPmcrOhpP1pHKk6gSf84BWPD5y5ygmN8M15QnccrJVMwQH2va/4EIYkKU67G2LFJyYdJi0Dl9Vsxv14+3m3y3noyYpr72SxHPw2KXO/vCkdk4ktGi/LyVr2WQsAR2+BRIrNB300HdCRPkM1QWZM7UfC0luZIu1fCRMeaxtM2G8ZEWQf5EfsSZ04mWVnhJmgeA16yL3fIT8EheO X-Forefront-PRVS: 0228DDDDD7 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(199003)(189002)(24454002)(377424004)(76176999)(33716001)(8676002)(42186005)(33656002)(2870700001)(2906002)(81156014)(4326007)(2950100002)(305945005)(81166006)(1076002)(7736002)(54356999)(105586002)(229853002)(106356001)(68736007)(101416001)(50986999)(4001350100001)(86362001)(92566002)(3846002)(83506001)(66066001)(6116002)(6666003)(6916009)(23756003)(97736004)(53936002)(110136004)(50466002)(189998001)(47776003)(6246003)(5660300001)(6496005)(9686003)(55016002)(54906002)(25786008)(38730400002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR05MB3285;H:ubuntu;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?iso-8859-1?Q?1;CY4PR05MB3285;23:8l+Qp5Ky+gcpmV7L5P87pIVpTJIzsLtXuapeKsS?= =?iso-8859-1?Q?T1UACGO/GeidFaB+U470JUT27RpAIsMiiE5XMQZZkDb0HYK0RtrQ9rl53c?= =?iso-8859-1?Q?oLJvSkWacCZGpRbX/nvIpAruYNmAedICYFS0T3G/QE8u+EL4tNPQTypHwc?= =?iso-8859-1?Q?F236spdCUVL1xBbfZ7tx9N63BF6fkeuqciC0N28HHRtuh96hRaG63oV/u1?= =?iso-8859-1?Q?EHHw0omRb1eaEPP4q0PXa6Up2dE7r9909y8c5IxXgv7ikPXUswXISX0Mz0?= =?iso-8859-1?Q?adfk/6K8WNsr6neMMbS69DrdKSecUquqEzstVV5XwN4ccRsbplx/D0j9sG?= =?iso-8859-1?Q?aIj0bON9s7ClF2UJmJvjP5797UpmPe7HPekPf+Ypl8uc3prj8xm2GBTY2X?= =?iso-8859-1?Q?9tC/bFvgxQkvko18CuUT7j/RrnGRItnc6pCtJNwgDlX6eNEQVwBlCzvKD/?= =?iso-8859-1?Q?xyDfiKZIrMTRKKvzKLLO29kDwvEzMyj0kiD69f925i/2AI8VLAb+h/ox+3?= =?iso-8859-1?Q?TwnuQQCBtm2FB0px8Pg31b/IJn8Xmu0k7sfLegavYh/JIHqJblpLyBVKPz?= =?iso-8859-1?Q?5JtB9EBQbLwRPXNCaVgLIXNI86Maavx+MBc/Tx1WwWtG7v+D5PsWIiZLFm?= =?iso-8859-1?Q?/+71EFCEl4oooqZ/mhASgpBFBQXNmT5hChcexVjjdt2jmb5vLBbKdaJ/00?= =?iso-8859-1?Q?+fWvrp9xnY+AzFjiOBYSsABgrNPB+KV44gcsjs+jWFjyPwEeE5jonCQbqn?= =?iso-8859-1?Q?lqVwqenZMJAmOM5BdVtTL2fUifdNoKVmuj4tcAFTTOvhrP257z+ZIN7Zja?= =?iso-8859-1?Q?+nrIJ0bSjZANRF0nX6YByiv6itMhlHkO5OkNSWub+8OKr7N4Mzfnh3qSNy?= =?iso-8859-1?Q?8Lp4wutZs3qO0cwsRW3iO+Z/LjMj7JwnUvbo42N4SWCGVa9l3mTQZZXMR2?= =?iso-8859-1?Q?xWcOV7HrvfNpUMNdMRklYj7coi7GebjI5n5tFBJcT0VmHw6UP5H6HaOpkT?= =?iso-8859-1?Q?LFRNN1wquooHz32hlEZUWSvdyCJZI1OELP1YDes3T1mvx1fO73z2Kj2ATH?= =?iso-8859-1?Q?X5ddVSA5Lbn+2l9/bDhbiDo5mlJWsxJmgYpSLaozcA0FWPnJenLyKFG/P+?= =?iso-8859-1?Q?336WY7R99RvBoQQ6SIQ6KDaa1/dxjQ1Edv5dlSZq86mQVobpRfZFIyGe3J?= =?iso-8859-1?Q?fD68L25q+uVDYdRZz+RZJF6khFIu9bvCAYBAUzHrg2u/kCg0wxsEYxJya5?= =?iso-8859-1?Q?4DtwmVaXB3x350e9rwL4rbPj99GzQ60pNNPiRBaTtJakzLelY01ZciKpP4?= =?iso-8859-1?Q?ew1ESYfuvDxIbb6vv3GS/571oovCESQob4TsXNDzKOB9w=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3285;6:vOIN/fIuNe7J0lJD8+u3v2StjI0ZS1dBHU4XFMtLLVD/O+xROz4zd2Qvapq2kE5yO6DOFvIQkVZRngcVC5UjeEEfnUGztE0b5XWFtYUdUDSHGmhCvLdjWaVScOo7ADlRHs0qQwykJLyGIRmioPKUdEVQE4LXZMWff7oYsimJ83OLowZj7y/Y+bbrGYmPcu9gNXZwJewFBWzGl4Fx+QfQgjZMPmhz5pOkMHyE2E5Ws8FmLKdh+jDWRlyISuQKEDrZIJ23liI+Gb+qr6G5b/5ZOA5VnT98mDw6fs50cJlVxpDqMModdgslMbWwm+tlKTjEyAv0DTu9qESU9NYp8gsEu60GQ9/eF3lGUD0acqG7iq2qGm4MzxIndRAvGQOpA0h2a7+6iYl0li3kUwqyNXCuxg==;5:rgPYdq6BshaVdZ8wHQcY19FKq8OnDkLfCjuPipgyhpBa0Mu+8mqMmyvvwCR13ZQr0Mb6gNG4xiCTAZMWuuyLuYdrDeBzAEBRrVFLt60+fFKwz49qqKotfEsYarXb6vkzFkllu1WZfdgNMpDgsgvJbg==;24:Bfwft+2VSRkl0hCKyRA1M8nvvUR9DfEgLPCPQeKgOzg1xciUyyMSJv2uTFojlX5o5C1niz2+Q/l9wqHIGU+76cgnMLlGLgce2SDbtjTpWiI= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR05MB3285;7:Mvs2Qzb+61N2EOmNefEH+01j69f0y40pKoyw7vUhc41u00yCrxlb0S7YBFpd+lFd1wtYfdWX2KhInEW17qmEuLRrcyd4I8bKDETlFulr21wyYTkwn03grBUQ6C3pNJr9q4xLigPRi5f7HLf2ewlKQpZVoS8aSwWvT5OMLmOP3w6zwPOoKGDCk9+IiShs/TQPxllscwNXW9l8AJ/q2v/Y62O0qKuoGeqUMGq9913dHDbmJhs/QOeHdfBhPQ1Sw1A/GmdawilnGhbiW3ddh7MEbrdbEzIm5XgCdsF3SbT28JQk/+A5ZCcBaJgesaKtqu2HhgWB3qXZOq5Xbd5pFtLtWg==;20:y/I8M+xhUszlD30ZGo4c1sVK8uUCq+dgapRfkTlqTKkpZis+eGnfVQMo0D7cr09FGM7H6T/gxlq3z97BsTG6z1BNSKgkbW4m93WlP0PHgDXUH0SaBBvy2Ktyp01Ww4tQaOcYSuFEptTU8B3Ks0EleLIeaR1zNIWXYxpWaDbudsU= X-OriginatorOrg: vmware.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2017 19:33:21.2961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR05MB3285 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 24, 2017 at 11:06:03AM -0800, Sinclair Yeh wrote: > Hi Oyvind, > > Thanks for looking at this. > > At this moment, I don't really see a benefit one way or anther, so > I am going to stick with the macro version for now, changing the one > remaining module_param_named() you mentioned to using the macros to > keep things consistent. > > If one day we have a paramter with a long ORing of the macros, then > we can revisit this decision. Actually, now that I see checkpatch.pl has been modified to prefer octal permissions, I think your suggestion is better. So I'll just take your patch instead. thanks! Sinclair > > Sinclair > > On Sat, Feb 04, 2017 at 07:17:27PM +0100, Øyvind A. Holm wrote: > > This reverts commit 2d8e60e8b0742b7a5cddc806fe38bb81ee876c33. > > > > The commit belongs to the series of 1285 patches sent to LKML on > > 2016-08-02, it changes the representation of file permissions from the > > octal value "0600" to "S_IRUSR | S_IWUSR". > > > > The general consensus was that the changes does not increase > > readability, quite the opposite; 0600 is easier to parse mentally than > > S_IRUSR | S_IWUSR. > > > > It also causes argument inconsistency, due to commit 04319d89fbec > > ("drm/vmwgfx: Add an option to change assumed FB bpp") that added > > another call to module_param_named() where the permissions are written > > as 0600. > > > > Signed-off-by: Øyvind A. Holm > > --- > > This is a resend of the patch originally sent on 2017-01-16. The only > > difference from v1 is an improved commit message with some more details. > > > > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > index 18061a4bc2f2..e8ae3dc476d1 100644 > > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > > @@ -241,15 +241,15 @@ static int vmwgfx_pm_notifier(struct notifier_block *nb, unsigned long val, > > void *ptr); > > > > MODULE_PARM_DESC(enable_fbdev, "Enable vmwgfx fbdev"); > > -module_param_named(enable_fbdev, enable_fbdev, int, S_IRUSR | S_IWUSR); > > +module_param_named(enable_fbdev, enable_fbdev, int, 0600); > > MODULE_PARM_DESC(force_dma_api, "Force using the DMA API for TTM pages"); > > -module_param_named(force_dma_api, vmw_force_iommu, int, S_IRUSR | S_IWUSR); > > +module_param_named(force_dma_api, vmw_force_iommu, int, 0600); > > MODULE_PARM_DESC(restrict_iommu, "Try to limit IOMMU usage for TTM pages"); > > -module_param_named(restrict_iommu, vmw_restrict_iommu, int, S_IRUSR | S_IWUSR); > > +module_param_named(restrict_iommu, vmw_restrict_iommu, int, 0600); > > MODULE_PARM_DESC(force_coherent, "Force coherent TTM pages"); > > -module_param_named(force_coherent, vmw_force_coherent, int, S_IRUSR | S_IWUSR); > > +module_param_named(force_coherent, vmw_force_coherent, int, 0600); > > MODULE_PARM_DESC(restrict_dma_mask, "Restrict DMA mask to 44 bits with IOMMU"); > > -module_param_named(restrict_dma_mask, vmw_restrict_dma_mask, int, S_IRUSR | S_IWUSR); > > +module_param_named(restrict_dma_mask, vmw_restrict_dma_mask, int, 0600); > > MODULE_PARM_DESC(assume_16bpp, "Assume 16-bpp when filtering modes"); > > module_param_named(assume_16bpp, vmw_assume_16bpp, int, 0600); > > > > -- > > 2.12.0.rc0 > >