From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751282AbdBXMCH (ORCPT <rfc822;w@1wt.eu>);
        Fri, 24 Feb 2017 07:02:07 -0500
Received: from mx0a-0016f401.pphosted.com ([67.231.148.174]:60350 "EHLO
        mx0b-0016f401.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1751080AbdBXMB6 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 24 Feb 2017 07:01:58 -0500
Date: Fri, 24 Feb 2017 19:56:48 +0800
From: Jisheng Zhang <jszhang@marvell.com>
To: David Miller <davem@davemloft.net>, <mw@semihalf.com>
CC: <gregory.clement@free-electrons.com>,
        <thomas.petazzoni@free-electrons.com>, <arnd@arndb.de>,
        <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v3 0/4] net: mvneta: improve rx/tx performance
Message-ID: <20170224195648.219d6b50@xhacker>
In-Reply-To: <20170221.111602.860315087619854954.davem@davemloft.net>
References: <20170220125344.3555-1-jszhang@marvell.com>
        <877f4laqog.fsf@free-electrons.com>     <20170221123726.2db7db19@xhacker>
        <20170221.111602.860315087619854954.davem@davemloft.net>
X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-24_06:,,
 signatures=0
X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000
 definitions=main-1702240120
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi David, Marcin,

On Tue, 21 Feb 2017 11:16:02 -0500 David Miller wrote:

> From: Jisheng Zhang <jszhang@marvell.com>
> Date: Tue, 21 Feb 2017 12:37:40 +0800
> 
> > Thanks for your review.
> > 
> > The measurement is simple: record how much time we spent in mvneta_rx_swbm()
> > for receiving 1GB data, something as below:  
> 
> Please use a standard tool for measuring performance, rather than profiling
> the driver and trying to derive numbers that way.

Got your point. I will try to get performance with standard tool and cook a
v4 once rc1 is released.

Thanks,
Jisheng