From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751470AbdBXUt6 (ORCPT ); Fri, 24 Feb 2017 15:49:58 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:52838 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219AbdBXUtu (ORCPT ); Fri, 24 Feb 2017 15:49:50 -0500 Date: Fri, 24 Feb 2017 20:49:41 +0000 From: Al Viro To: Peter Zijlstra Cc: Linus Torvalds , Chris Mason , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, David Howells , elena.reshetova@intel.com, ishkamiel@gmail.com, dwindsor@gmail.com, gregkh@linuxfoundation.org Subject: Re: [RFC][PATCH 06/10] fs: Rework i_count Message-ID: <20170224204941.GO29622@ZenIV.linux.org.uk> References: <20170224154329.478276481@infradead.org> <20170224162044.267733351@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170224162044.267733351@infradead.org> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 24, 2017 at 04:43:35PM +0100, Peter Zijlstra wrote: > { > - return atomic_read(&inode->i_count); > + int i_count = atomic_read(&inode->i_count); > + > + /* > + * In order to preserve the 'old' usage-count semantics, remove the > + * reference that the hash-table has. What does it have to do with hashtable, when you are bumping it for _all_ inodes, hashed or not hashed?