From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751460AbdBXUwq (ORCPT ); Fri, 24 Feb 2017 15:52:46 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:52920 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751293AbdBXUw2 (ORCPT ); Fri, 24 Feb 2017 15:52:28 -0500 Date: Fri, 24 Feb 2017 20:52:22 +0000 From: Al Viro To: Peter Zijlstra Cc: Linus Torvalds , Chris Mason , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, David Howells , elena.reshetova@intel.com, ishkamiel@gmail.com, dwindsor@gmail.com, gregkh@linuxfoundation.org Subject: Re: [RFC][PATCH 07/10] orangefs: Use RCU for destroy_inode Message-ID: <20170224205222.GP29622@ZenIV.linux.org.uk> References: <20170224154329.478276481@infradead.org> <20170224162044.333662852@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170224162044.333662852@infradead.org> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org That, AFAICS, fixes a real bug. Applied, and it needs Cc:stable as well. > Signed-off-by: Peter Zijlstra (Intel) > --- > fs/orangefs/super.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > --- a/fs/orangefs/super.c > +++ b/fs/orangefs/super.c > @@ -115,6 +115,13 @@ static struct inode *orangefs_alloc_inod > return &orangefs_inode->vfs_inode; > } > > +static void orangefs_i_callback(struct rcu_head *head) > +{ > + struct inode *inode = container_of(head, struct inode, i_rcu); > + struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode); > + kmem_cache_free(orangefs_inode_cache, orangefs_inode); > +} > + > static void orangefs_destroy_inode(struct inode *inode) > { > struct orangefs_inode_s *orangefs_inode = ORANGEFS_I(inode); > @@ -123,7 +130,7 @@ static void orangefs_destroy_inode(struc > "%s: deallocated %p destroying inode %pU\n", > __func__, orangefs_inode, get_khandle_from_ino(inode)); > > - kmem_cache_free(orangefs_inode_cache, orangefs_inode); > + call_rcu(&inode->i_rcu, orangefs_i_callback); > } > > /* > >