Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)

Pavel Machek
2017-03-03T23:24:13Z

[-- Attachment #1: Type: text/plain, Size: 3353 bytes --]

Hi!

> > > > > Making the sub-device bus configuration a pointer should be in a separate
> > > > > patch. It makes sense since the entire configuration is not valid for all
> > > > > sub-devices attached to the ISP anymore. I think it originally was a
> > > > > separate patch, but they probably have been merged at some point. I can't
> > > > > find it right now anyway.
> > > >
> > > > Something like this?
> > > >
> > > > commit df9141c66678b549fac9d143bd55ed0b242cf36e
> > > > Author: Pavel <pavel@ucw.cz>
> > > > Date: Wed Mar 1 13:27:56 2017 +0100
> > > >
> > > > Turn bus in struct isp_async_subdev into pointer; some of our subdevs
> > > > (flash, focus) will not need bus configuration.
> > > >
> > > > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > >
> > > I applied this to the ccp2 branch with an improved patch
> > > description.
> >
> > Thanks!
> >
> > [But the important part is to get subdevices to work on ccp2 based
> > branch, and it still fails to work at all if I attempt to enable
> > them. I'd like to understand why...]
>
> Did you add the flash / lens to the async list? The patches currently in the
> ccp branch do not include that --- it should be in parsing the flash /
> lens-focus properties in omap3isp device's node.

I retried, and it fails different way than I assumed. I might be able
to debug this one as sensor (and mplayer) still works.

Best regards,
Pavel

--

This is what subdevs support should look like, I guess; but I don't
know fwnode stuff well enough.

diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
index c80397a..36bd359 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -2166,6 +2166,8 @@ static int isp_fwnodes_parse(struct device *dev,
struct v4l2_async_notifier *notifier)
{
struct fwnode_handle *fwn = NULL;
+ struct device_node *node;
+ int flash = 0;

notifier->subdevs = devm_kcalloc(
dev, ISP_MAX_SUBDEVS, sizeof(*notifier->subdevs), GFP_KERNEL);
@@ -2199,6 +2201,42 @@ static int isp_fwnodes_parse(struct device *dev,
notifier->num_subdevs++;
}

+ printk("Going through camera-flashes\n");
+ while (notifier->num_subdevs < ISP_MAX_SUBDEVS) {
+ /* FIXME: fwnode_graph_get_remote_endpoint()
+ (fwn = fwnode_graph_get_next_endpoint(device_fwnode_handle(dev), fwn, )) */
+ struct isp_async_subdev *isd;
+
+ node = of_parse_phandle(dev->of_node, "ti,camera-flashes", flash++);
+ flash++;
+ if (!node)
+ break;
+
+ printk("Having subdevice: %p\n", node);
+
+#if 1
+ isd = devm_kzalloc(dev, sizeof(*isd), GFP_KERNEL);
+ if (!isd)
+ goto error;
+
+ notifier->subdevs[notifier->num_subdevs] = &isd->asd;
+
+
+ isd->asd.match.of.node = node;
+ if (!isd->asd.match.of.node) {
+ dev_warn(dev, "bad remote port parent\n");
+ goto error;
+ }
+
+ isd->asd.match_type = V4L2_ASYNC_MATCH_OF;
+ notifier->num_subdevs++;
+#endif
+ }
+
+
+ if (notifier->num_subdevs == ISP_MAX_SUBDEVS) {
+ printk("isp: Maybe too many devices?\n");
+ }
return notifier->num_subdevs;