Re: camera subdevice support was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times

Pavel Machek
2017-03-04T08:55:57Z

[-- Attachment #1: Type: text/plain, Size: 4732 bytes --]

Dobry den! :-)

> > > > Ok, I got the camera sensor to work. No subdevices support, so I don't
> > > > have focus (etc) working, but that's a start. I also had to remove
> > > > video-bus-switch support; but I guess it will be easier to use
> > > > video-multiplexer patches...
> > > >
> > > > I'll have patches over weekend.
> > >
> > > I briefly looked at what's there --- you do miss the video nodes for the
> > > non-sensor sub-devices, and they also don't show up in the media graph,
> > > right?
> >
> > Yes.
> >
> > > I guess they don't end up matching in the async list.
> >
> > How should they get to the async list?
>
> The patch you referred to does that. The problem is, it does make the bus
> configuration a pointer as well. There should be two patches. That's not a
> lot of work to separate them though. But it should be done.
>
> >
> > > I think we need to make the non-sensor sub-device support more generic;
> > > it's not just the OMAP 3 ISP that needs it. I think we need to document
> > > the property for the flash phandle as well; I can write one, or refresh
> > > an existing one that I believe already exists.
> > >
> > > How about calling it either simply "flash" or "camera-flash"? Similarly
> > > for lens: "lens" or "camera-lens". I have a vague feeling the "camera-"
> > > prefix is somewhat redundant, so I'd just go for "flash" or "lens".
> >
> > Actually, I'd go for "flash" and "focus-coil". There may be other
> > lens properties, such as zoom, mirror movement, lens identification,
> > ...
>
> Good point. Still there may be other ways to move the lens than the voice
> coil (which sure is cheap), so how about "flash" and "lens-focus"?

Ok, so something like this? (Yes, needs binding documentation and you
wanted it in the core.. can fix.)

BTW, fwnode_handle_put() seems to be missing in the success path of
isp_fwnodes_parse() -- can you check that?

Best regards,
Pavel

diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
index c80397a..6f6fbed 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -2114,7 +2114,7 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwn,
buscfg->bus.ccp2.lanecfg.data[0].pol =
vfwn.bus.mipi_csi1.lane_polarity[1];

- dev_dbg(dev, "data lane %u polarity %u, pos %u\n", i,
+ dev_dbg(dev, "data lane %u polarity %u, pos %u\n", 0,
buscfg->bus.ccp2.lanecfg.data[0].pol,
buscfg->bus.ccp2.lanecfg.data[0].pos);

@@ -2162,10 +2162,64 @@ static int isp_fwnode_parse(struct device *dev, struct fwnode_handle *fwn,
return 0;
}

+static int camera_subdev_parse(struct device *dev, struct v4l2_async_notifier *notifier,
+ const char *key)
+{
+ struct device_node *node;
+ struct isp_async_subdev *isd;
+
+ printk("Looking for %s\n", key);
+
+ node = of_parse_phandle(dev->of_node, key, 0);
+ if (!node)
+ return 0;
+
+ printk("Having subdevice: %p\n", node);
+
+ isd = devm_kzalloc(dev, sizeof(*isd), GFP_KERNEL);
+ if (!isd)
+ return -ENOMEM;
+
+ notifier->subdevs[notifier->num_subdevs] = &isd->asd;
+
+ isd->asd.match.of.node = node;
+ if (!isd->asd.match.of.node) {
+ dev_warn(dev, "bad remote port parent\n");
+ return -EIO;
+ }
+
+ isd->asd.match_type = V4L2_ASYNC_MATCH_OF;
+ notifier->num_subdevs++;
+
+ return 0;
+}
+
+static int camera_subdevs_parse(struct device *dev, struct v4l2_async_notifier *notifier,
+ int max)
+{
+ int res = 0;
+
+ printk("Going through camera-flashes\n");
+ if (notifier->num_subdevs < max) {
+ res = camera_subdev_parse(dev, notifier, "flash");
+ if (res)
+ return res;
+ }
+
+ if (notifier->num_subdevs < max) {
+ res = camera_subdev_parse(dev, notifier, "lens-focus");
+ if (res)
+ return res;
+ }
+
+ return 0;
+}
+
static int isp_fwnodes_parse(struct device *dev,
struct v4l2_async_notifier *notifier)
{
struct fwnode_handle *fwn = NULL;
+ int res = 0;

notifier->subdevs = devm_kcalloc(
dev, ISP_MAX_SUBDEVS, sizeof(*notifier->subdevs), GFP_KERNEL);
@@ -2199,6 +2253,15 @@ static int isp_fwnodes_parse(struct device *dev,
notifier->num_subdevs++;
}

+ /* FIXME: missing put in the success path? */
+
+ res = camera_subdevs_parse(dev, notifier, ISP_MAX_SUBDEVS);
+ if (res)
+ goto error;
+
+ if (notifier->num_subdevs == ISP_MAX_SUBDEVS) {
+ printk("isp: Maybe too many devices?\n");
+ }
return notifier->num_subdevs;