Re: subdevice config into pointer (was Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times)

Pavel Machek
2017-03-02T14:58:42Z

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

Hi!

> > > Making the sub-device bus configuration a pointer should be in a separate
> > > patch. It makes sense since the entire configuration is not valid for all
> > > sub-devices attached to the ISP anymore. I think it originally was a
> > > separate patch, but they probably have been merged at some point. I can't
> > > find it right now anyway.
> >
> > Something like this?
> >
> > commit df9141c66678b549fac9d143bd55ed0b242cf36e
> > Author: Pavel <pavel@ucw.cz>
> > Date: Wed Mar 1 13:27:56 2017 +0100
> >
> > Turn bus in struct isp_async_subdev into pointer; some of our subdevs
> > (flash, focus) will not need bus configuration.
> >
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> I applied this to the ccp2 branch with an improved patch
> description.

Thanks!

[But the important part is to get subdevices to work on ccp2 based
branch, and it still fails to work at all if I attempt to enable
them. I'd like to understand why...]