From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751807AbdBYHzo (ORCPT ); Sat, 25 Feb 2017 02:55:44 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37586 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751559AbdBYHzl (ORCPT ); Sat, 25 Feb 2017 02:55:41 -0500 X-ME-Sender: X-Sasl-enc: Kqm5gupNBpZ2wVwhWB9hUyNFVcd+dfWpKjnjFgS1ZhF7 1488009301 Date: Sat, 25 Feb 2017 08:54:32 +0100 From: Greg KH To: SIMRAN SINGHAL Cc: outreachy-kernel , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [Outreachy kernel] Re: [PATCH v2 3/3] staging: rtl8192u: Prefer using the BIT macro Message-ID: <20170225075432.GC1614@kroah.com> References: <20170217175059.GA26957@singhal-Inspiron-5558> <20170224171613.GA376@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 24, 2017 at 12:10:21PM -0800, SIMRAN SINGHAL wrote: > > > On Friday, February 24, 2017 at 10:46:21 PM UTC+5:30, gregkh wrote: > > On Fri, Feb 17, 2017 at 11:20:59PM +0530, simran singhal wrote: > > Replaces left shift operation (1 << d) by BIT(x) macro. > > > > Fix the checkpatch.pl issue: > > CHECK: Prefer using the BIT macro replacing > > > > Signed-off-by: simran singhal > > --- > >   > >  V2: > >    -modified patch message. > > > >  drivers/staging/rtl8192u/ieee80211/ieee80211.h | 140 > ++++++++++++------------- > >  1 file changed, 70 insertions(+), 70 deletions(-) > > The last chunk of this patch did not apply, please fix up and resend. > > thanks, > > greg k-h > > >   Can you please elaborate what's the problem with the last chunk of this patch > and  >   to be more precise what do you mean by "last chunk of this patch". I am not > getting  >   what's the problem with this patch. I don't know what the problem was, just that it did not apply properly. Take your patch and try to apply it now to my tree and see what happens... thanks, greg k-h