From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751810AbdBYILl (ORCPT ); Sat, 25 Feb 2017 03:11:41 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:38386 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751599AbdBYIL3 (ORCPT ); Sat, 25 Feb 2017 03:11:29 -0500 X-ME-Sender: X-Sasl-enc: Oc8ipO6bIQDNrkW3BwGsihnZwRQ1Se5Mj6qZH9XTwh9l 1488009765 Date: Sat, 25 Feb 2017 09:02:18 +0100 From: Greg KH To: Long Li Cc: KY Srinivasan , Haiyang Zhang , Bjorn Helgaas , "devel@linuxdriverproject.org" , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" Subject: Re: [Resend PATCH 2/2 v3] pci-hyperv: lock pci bus on device eject Message-ID: <20170225080218.GA2291@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 24, 2017 at 09:49:17PM +0000, Long Li wrote: > A PCI_EJECT message can arrive at the same time we are calling pci_scan_child_bus in the workqueue for the previous PCI_BUS_RELATIONS message or in create_root_hv_pci_bus(), in this case we could potentailly modify the bus from multiple places. Properly lock the bus access. Properly wrap your changelog comments at 72 columns like your editor is telling you to do...