From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751866AbdBYQHS (ORCPT <rfc822;w@1wt.eu>);
        Sat, 25 Feb 2017 11:07:18 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:41280 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751692AbdBYQHR (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 25 Feb 2017 11:07:17 -0500
Date: Sat, 25 Feb 2017 16:06:49 +0000
From: Al Viro <viro@ZenIV.linux.org.uk>
To: "Theodore Ts'o" <tytso@mit.edu>, bosrsf04@gmail.com,
        Andrew Morton <akpm@linux-foundation.org>,
        Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
        Ingo Molnar <mingo@kernel.org>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>,
        Andy Lutomirski <luto@kernel.org>,
        Nicolas Pitre <nicolas.pitre@linaro.org>,
        Petr Mladek <pmladek@suse.com>, Helge Deller <deller@gmx.de>,
        Rik van Riel <riel@redhat.com>, Thomas Garnier <thgarnie@google.com>,
        Parav Pandit <pandit.parav@gmail.com>,
        "seokhoon . yoon" <iamyooon@gmail.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dave Hansen <dave.hansen@intel.com>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, josh@joshtriplett.org,
        brkkurek192@gmail.com, conorcurry@gmail.com, fanofbond138@gmail.com
Subject: Re: [PATCH 2/3] fs: Extracts pivot_root so it can be made optional
Message-ID: <20170225160648.GQ29622@ZenIV.linux.org.uk>
References: <cover.1487974516.git.bosrsf04@gmail.com>
 <d2f07062a3c946ea32b602351823f6ce6dac8533.1487974517.git.bosrsf04@gmail.com>
 <20170225152221.v7yah6d25scxaijf@thunk.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170225152221.v7yah6d25scxaijf@thunk.org>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Feb 25, 2017 at 10:22:21AM -0500, Theodore Ts'o wrote:
> If you're only going to be removing a single function, instead of
> having to export a bunch of previously-static functions, my preference
> would be to just insert a pair of #ifdef CONFIG_PIVOT_ROOT_SYSCALL / #endif
> statements around the function in question.

Quite.  In this form: NAK for the reasons above.