From: Mike Rapoport <rppt@linux.vnet.ibm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Shuah Khan <shuahkh@osg.samsung.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [GIT PULL] Kselftest update for 4.11-rc1
Date: Sun, 26 Feb 2017 13:37:44 +0200 [thread overview]
Message-ID: <20170226113744.GA17152@rapoport-lnx> (raw)
In-Reply-To: <CA+55aFy9TiUb0nXyFNT0ZSxVkpyQme0reB54ZNCQpanof+wqew@mail.gmail.com>
On Sat, Feb 25, 2017 at 03:42:55PM -0800, Linus Torvalds wrote:
> On Fri, Feb 24, 2017 at 1:09 PM, Shuah Khan <shuahkh@osg.samsung.com> wrote:
> >
> > Stephen saw a conflict during kselftest merge with next
> [..]
>
> There was also a conflict with some of Andrew's new userfaultfd tests.
>
> I'm not at all sure I merged that correctly, although I tried to make
> the resolution at least look sane. The odd thing about those new tests
> is that it's all the same source file, except built with different
> compile-time defines to be different test binaries.
>
> I didn't find any way to do that with any standard selftest makefile
> magic, so I just did the build rules by hand.
>
> Somebody should actually verify that it does the right thing, please..
> Adding the two Mike's that did those test additions to the participant
> list.
The userfaultfd_* tests are built and they are working just fine.
Maybe it's worth adding userfaultfd_{hugetlb,shmem}.c which will define the
required defines and include userfaultfd.c?
Than we can get away with only specifying LDFLAGS += -lpthread in the
Makefile.
> Linus
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2017-02-26 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 21:09 [GIT PULL] Kselftest update for 4.11-rc1 Shuah Khan
2017-02-25 23:42 ` Linus Torvalds
2017-02-26 11:37 ` Mike Rapoport [this message]
2017-02-26 20:40 ` Mike Kravetz
2017-02-27 22:14 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170226113744.GA17152@rapoport-lnx \
--to=rppt@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=sfr@canb.auug.org.au \
--cc=shuahkh@osg.samsung.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox