From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: pjambhlekar <pushkar.iit@gmail.com>
Cc: "Laura Abbott" <labbott@redhat.com>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Riley Andrews" <riandrews@android.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Fixing coding guidelines in drivers/staging/android/ion/*
Date: Sun, 26 Feb 2017 18:06:30 +0100 [thread overview]
Message-ID: <20170226170630.GA15440@kroah.com> (raw)
In-Reply-To: <1488128042-13880-2-git-send-email-pushkar.iit@gmail.com>
On Sun, Feb 26, 2017 at 10:24:02PM +0530, pjambhlekar wrote:
> Signed-off-by: pjambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/android/ion/ion-ioctl.c | 2 +-
> drivers/staging/android/ion/ion.c | 8 ++++----
> drivers/staging/android/ion/ion_cma_heap.c | 3 +--
> drivers/staging/android/ion/ion_dummy_driver.c | 2 +-
> drivers/staging/android/ion/ion_system_heap.c | 2 --
> 5 files changed, 7 insertions(+), 10 deletions(-)
How come you didn't read what my patch-bot sent you the last time you
sent me this patch? Please fix up the problems it found last time and
resend if you wish for us to be able to review this patch (hint, I can't
take a path with no changelog text, and you forgot to use
get_maintainer.pl to find the correct mailing list to cc:).
Also, I need a "full" name in your from and signed-off-by line, unless
you really only use one word for when you sign legal documents?
Take your time, relax, fix things up, resend it to yourself first to
verify you got it all correct, and then you can send it to us. Please
take at least a day to do this before resending, there is no rush.
thanks,
greg k-h
prev parent reply other threads:[~2017-02-26 17:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 16:54 [PATCH 0/1] Fixing coding guidelines in drivers/staging/android/ion pjambhlekar
2017-02-26 16:54 ` [PATCH 1/1] Fixing coding guidelines in drivers/staging/android/ion/* pjambhlekar
2017-02-26 17:06 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170226170630.GA15440@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pushkar.iit@gmail.com \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox