From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751410AbdBZRGl (ORCPT ); Sun, 26 Feb 2017 12:06:41 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39052 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750911AbdBZRGk (ORCPT ); Sun, 26 Feb 2017 12:06:40 -0500 Date: Sun, 26 Feb 2017 18:06:30 +0100 From: Greg Kroah-Hartman To: pjambhlekar Cc: Laura Abbott , Sumit Semwal , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , Riley Andrews , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] Fixing coding guidelines in drivers/staging/android/ion/* Message-ID: <20170226170630.GA15440@kroah.com> References: <1488128042-13880-1-git-send-email-pushkar.iit@gmail.com> <1488128042-13880-2-git-send-email-pushkar.iit@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488128042-13880-2-git-send-email-pushkar.iit@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 26, 2017 at 10:24:02PM +0530, pjambhlekar wrote: > Signed-off-by: pjambhlekar > --- > drivers/staging/android/ion/ion-ioctl.c | 2 +- > drivers/staging/android/ion/ion.c | 8 ++++---- > drivers/staging/android/ion/ion_cma_heap.c | 3 +-- > drivers/staging/android/ion/ion_dummy_driver.c | 2 +- > drivers/staging/android/ion/ion_system_heap.c | 2 -- > 5 files changed, 7 insertions(+), 10 deletions(-) How come you didn't read what my patch-bot sent you the last time you sent me this patch? Please fix up the problems it found last time and resend if you wish for us to be able to review this patch (hint, I can't take a path with no changelog text, and you forgot to use get_maintainer.pl to find the correct mailing list to cc:). Also, I need a "full" name in your from and signed-off-by line, unless you really only use one word for when you sign legal documents? Take your time, relax, fix things up, resend it to yourself first to verify you got it all correct, and then you can send it to us. Please take at least a day to do this before resending, there is no rush. thanks, greg k-h