Re: [PATCH 1/1] Fixing coding guidelines in drivers/staging/android/ion/*

Greg Kroah-Hartman
2017-02-26T17:06:41Z

On Sun, Feb 26, 2017 at 10:24:02PM +0530, pjambhlekar wrote:
> Signed-off-by: pjambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/android/ion/ion-ioctl.c | 2 +-
> drivers/staging/android/ion/ion.c | 8 ++++----
> drivers/staging/android/ion/ion_cma_heap.c | 3 +--
> drivers/staging/android/ion/ion_dummy_driver.c | 2 +-
> drivers/staging/android/ion/ion_system_heap.c | 2 --
> 5 files changed, 7 insertions(+), 10 deletions(-)

How come you didn't read what my patch-bot sent you the last time you
sent me this patch? Please fix up the problems it found last time and
resend if you wish for us to be able to review this patch (hint, I can't
take a path with no changelog text, and you forgot to use
get_maintainer.pl to find the correct mailing list to cc:).

Also, I need a "full" name in your from and signed-off-by line, unless
you really only use one word for when you sign legal documents?

Take your time, relax, fix things up, resend it to yourself first to
verify you got it all correct, and then you can send it to us. Please
take at least a day to do this before resending, there is no rush.

thanks,

greg k-h