From: "Tobin C. Harding" <me@tobin.cc>
To: Matthew Giassa <matthew@giassa.net>
Cc: wsa@the-dreams.de, linux-renesas-soc@vger.kernel.org,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses.
Date: Mon, 27 Feb 2017 16:56:51 +1100 [thread overview]
Message-ID: <20170227055651.GA7536@eros> (raw)
In-Reply-To: <1488160822-18751-2-git-send-email-matthew@giassa.net>
On Sun, Feb 26, 2017 at 06:00:19PM -0800, Matthew Giassa wrote:
> ---
> drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +++++++++++++++++-----------------
> 1 file changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h
> index 8e62b10..47c8015 100644
> --- a/drivers/staging/ks7010/ks_wlan_ioctl.h
> +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h
> @@ -15,43 +15,43 @@
> #include <linux/wireless.h>
> /* The low order bit identify a SET (0) or a GET (1) ioctl. */
Patches without a git log won't be able to be merged. Please see
Documentation/process/submitting-patches.rst
thanks,
Tobin.
>
> -/* SIOCIWFIRSTPRIV + 0 */
> -/* former KS_WLAN_GET_DRIVER_VERSION SIOCIWFIRSTPRIV + 1 */
> -/* SIOCIWFIRSTPRIV + 2 */
> -#define KS_WLAN_GET_FIRM_VERSION SIOCIWFIRSTPRIV + 3
> +/* (SIOCIWFIRSTPRIV + 0) */
> +/* former KS_WLAN_GET_DRIVER_VERSION (SIOCIWFIRSTPRIV + 1) */
> +/* (SIOCIWFIRSTPRIV + 2) */
> +#define KS_WLAN_GET_FIRM_VERSION (SIOCIWFIRSTPRIV + 3)
> #ifdef WPS
> -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4
> -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV + 5
> -#define KS_WLAN_SET_WPS_PROBE_REQ SIOCIWFIRSTPRIV + 6
> +#define KS_WLAN_SET_WPS_ENABLE (SIOCIWFIRSTPRIV + 4)
> +#define KS_WLAN_GET_WPS_ENABLE (SIOCIWFIRSTPRIV + 5)
> +#define KS_WLAN_SET_WPS_PROBE_REQ (SIOCIWFIRSTPRIV + 6)
> #endif
> -#define KS_WLAN_GET_EEPROM_CKSUM SIOCIWFIRSTPRIV + 7
> -#define KS_WLAN_SET_PREAMBLE SIOCIWFIRSTPRIV + 8
> -#define KS_WLAN_GET_PREAMBLE SIOCIWFIRSTPRIV + 9
> -#define KS_WLAN_SET_POWER_SAVE SIOCIWFIRSTPRIV + 10
> -#define KS_WLAN_GET_POWER_SAVE SIOCIWFIRSTPRIV + 11
> -#define KS_WLAN_SET_SCAN_TYPE SIOCIWFIRSTPRIV + 12
> -#define KS_WLAN_GET_SCAN_TYPE SIOCIWFIRSTPRIV + 13
> -#define KS_WLAN_SET_RX_GAIN SIOCIWFIRSTPRIV + 14
> -#define KS_WLAN_GET_RX_GAIN SIOCIWFIRSTPRIV + 15
> -#define KS_WLAN_HOSTT SIOCIWFIRSTPRIV + 16 /* unused */
> -//#define KS_WLAN_SET_REGION SIOCIWFIRSTPRIV + 17
> -#define KS_WLAN_SET_BEACON_LOST SIOCIWFIRSTPRIV + 18
> -#define KS_WLAN_GET_BEACON_LOST SIOCIWFIRSTPRIV + 19
> +#define KS_WLAN_GET_EEPROM_CKSUM (SIOCIWFIRSTPRIV + 7)
> +#define KS_WLAN_SET_PREAMBLE (SIOCIWFIRSTPRIV + 8)
> +#define KS_WLAN_GET_PREAMBLE (SIOCIWFIRSTPRIV + 9)
> +#define KS_WLAN_SET_POWER_SAVE (SIOCIWFIRSTPRIV + 10)
> +#define KS_WLAN_GET_POWER_SAVE (SIOCIWFIRSTPRIV + 11)
> +#define KS_WLAN_SET_SCAN_TYPE (SIOCIWFIRSTPRIV + 12)
> +#define KS_WLAN_GET_SCAN_TYPE (SIOCIWFIRSTPRIV + 13)
> +#define KS_WLAN_SET_RX_GAIN (SIOCIWFIRSTPRIV + 14)
> +#define KS_WLAN_GET_RX_GAIN (SIOCIWFIRSTPRIV + 15)
> +#define KS_WLAN_HOSTT (SIOCIWFIRSTPRIV + 16) /* unused */
> +//#define KS_WLAN_SET_REGION (SIOCIWFIRSTPRIV + 17)
> +#define KS_WLAN_SET_BEACON_LOST (SIOCIWFIRSTPRIV + 18)
> +#define KS_WLAN_GET_BEACON_LOST (SIOCIWFIRSTPRIV + 19)
>
> -#define KS_WLAN_SET_TX_GAIN SIOCIWFIRSTPRIV + 20
> -#define KS_WLAN_GET_TX_GAIN SIOCIWFIRSTPRIV + 21
> +#define KS_WLAN_SET_TX_GAIN (SIOCIWFIRSTPRIV + 20)
> +#define KS_WLAN_GET_TX_GAIN (SIOCIWFIRSTPRIV + 21)
>
> /* for KS7010 */
> -#define KS_WLAN_SET_PHY_TYPE SIOCIWFIRSTPRIV + 22
> -#define KS_WLAN_GET_PHY_TYPE SIOCIWFIRSTPRIV + 23
> -#define KS_WLAN_SET_CTS_MODE SIOCIWFIRSTPRIV + 24
> -#define KS_WLAN_GET_CTS_MODE SIOCIWFIRSTPRIV + 25
> -/* SIOCIWFIRSTPRIV + 26 */
> -/* SIOCIWFIRSTPRIV + 27 */
> -#define KS_WLAN_SET_SLEEP_MODE SIOCIWFIRSTPRIV + 28 /* sleep mode */
> -#define KS_WLAN_GET_SLEEP_MODE SIOCIWFIRSTPRIV + 29 /* sleep mode */
> -/* SIOCIWFIRSTPRIV + 30 */
> -/* SIOCIWFIRSTPRIV + 31 */
> +#define KS_WLAN_SET_PHY_TYPE (SIOCIWFIRSTPRIV + 22)
> +#define KS_WLAN_GET_PHY_TYPE (SIOCIWFIRSTPRIV + 23)
> +#define KS_WLAN_SET_CTS_MODE (SIOCIWFIRSTPRIV + 24)
> +#define KS_WLAN_GET_CTS_MODE (SIOCIWFIRSTPRIV + 25)
> +/* (SIOCIWFIRSTPRIV + 26) */
> +/* (SIOCIWFIRSTPRIV + 27) */
> +#define KS_WLAN_SET_SLEEP_MODE (SIOCIWFIRSTPRIV + 28) /* sleep mode */
> +#define KS_WLAN_GET_SLEEP_MODE (SIOCIWFIRSTPRIV + 29) /* sleep mode */
> +/* (SIOCIWFIRSTPRIV + 30) */
> +/* (SIOCIWFIRSTPRIV + 31) */
>
> #ifdef __KERNEL__
>
> --
> 2.7.4
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2017-02-27 6:07 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 4:20 [PATCH] staging/ks7010: formatting updates Matthew Giassa
2017-02-21 7:59 ` Geert Uytterhoeven
2017-02-21 14:12 ` Matthew Giassa
2017-02-21 14:22 ` Geert Uytterhoeven
2017-02-21 17:32 ` Matthew Giassa
2017-02-21 18:47 ` Joe Perches
2017-02-21 19:48 ` Matthew Giassa
2017-02-21 20:02 ` Joe Perches
2017-02-22 21:52 ` [PATCHv2] Checkpatch fixes for staging/drivers/ks7010 Matthew Giassa
2017-02-24 17:12 ` Greg KH
2017-02-27 2:00 ` [PATCHv3] checkpatch fixes for drivers/staging/ks7010/ks_wlan_ioctl.h Matthew Giassa
2017-02-27 2:00 ` [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses Matthew Giassa
2017-02-27 2:00 ` [PATCHv3 2/4] Removing trailing whitespace in comment block Matthew Giassa
2017-02-27 2:00 ` [PATCHv3 3/4] Removing mixed spaces/hard-tabs in the alignment indentation to appease checkpatch Matthew Giassa
2017-02-27 2:00 ` [PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors) Matthew Giassa
2017-02-27 9:19 ` Sergei Shtylyov
2017-02-27 5:56 ` Tobin C. Harding [this message]
2017-03-15 2:25 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa
2017-03-15 2:25 ` [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa
2017-03-15 2:25 ` [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes Matthew Giassa
2017-03-15 2:25 ` [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses Matthew Giassa
2017-03-15 3:14 ` Tobin C. Harding
2017-03-15 20:27 ` Matthew Giassa
2017-03-16 2:42 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Greg KH
2017-03-16 3:18 ` [PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes Matthew Giassa
2017-03-16 3:18 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa
2017-03-17 6:22 ` Greg KH
2017-03-17 6:23 ` Greg KH
2017-03-16 3:18 ` [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa
2017-03-16 3:18 ` [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes Matthew Giassa
2017-03-16 3:18 ` [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses Matthew Giassa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227055651.GA7536@eros \
--to=me@tobin.cc \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=matthew@giassa.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox