From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751668AbdB0Plj (ORCPT ); Mon, 27 Feb 2017 10:41:39 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34808 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbdB0Plf (ORCPT ); Mon, 27 Feb 2017 10:41:35 -0500 Date: Mon, 27 Feb 2017 15:22:47 +0100 From: Greg KH To: Derek Robson Cc: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com, binoy.jayan@linaro.org, arnd@arndb.de, bhumirks@gmail.com, shaily15297@yahoo.com, raphael.beamonte@gmail.com, becher.jannik@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/9] Staging: rtl8712: rtl871x_mp_ioctl.h - style fix Message-ID: <20170227142247.GA16503@kroah.com> References: <2766636898e46cb49ac68feeb49819c4caf7e9b0.1488075534.git.robsonde@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2766636898e46cb49ac68feeb49819c4caf7e9b0.1488075534.git.robsonde@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 26, 2017 at 03:32:08PM +1300, Derek Robson wrote: > Fixed style of block comments > Found using checkpatch > > Signed-off-by: Derek Robson > --- > drivers/staging/rtl8712/rtl871x_mp_ioctl.h | 32 +++++++++++++++--------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_mp_ioctl.h b/drivers/staging/rtl8712/rtl871x_mp_ioctl.h > index 1102451a733d..c99a6dbae476 100644 > --- a/drivers/staging/rtl8712/rtl871x_mp_ioctl.h > +++ b/drivers/staging/rtl8712/rtl871x_mp_ioctl.h > @@ -162,26 +162,26 @@ static const struct oid_obj_priv oid_rtl_seg_81_80_00[] = { > */ > {1, oid_rt_pro_set_channel_direct_call_hdl}, /*0x08*/ > {1, oid_null_function}, /*0x09 > - * OID_RT_PRO_SET_SLEEP_MODE_DIRECT_CALL > - */ > + * OID_RT_PRO_SET_SLEEP_MODE_DIRECT_CALL > + */ > {1, oid_null_function}, /*0x0A > - * OID_RT_PRO_SET_WAKE_MODE_DIRECT_CALL > - */ > + * OID_RT_PRO_SET_WAKE_MODE_DIRECT_CALL > + */ > {1, oid_rt_pro_set_continuous_tx_hdl}, /*0x0B > - * OID_RT_PRO_SET_TX_CONTINUOUS_DIRECT_CALL > - */ > + * OID_RT_PRO_SET_TX_CONTINUOUS_DIRECT_CALL Now you are going out beyond 80 columns, which is what caused someone to move the comment to the left earlier :( Just put the comment in a single line, above the data definition, like this: /* 0x0B OID_RT_PRO_SET_TX_CONTINUOUS_DIRECT_CALL */ {1, oid_rt_pro_set_continuous_tx_hdl}, Which makes it easier for everyone to read and understand, which is the main goal of cleaning up code. thanks, greg k-h