From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751582AbdB0Orx (ORCPT ); Mon, 27 Feb 2017 09:47:53 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57922 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbdB0Oru (ORCPT ); Mon, 27 Feb 2017 09:47:50 -0500 Date: Mon, 27 Feb 2017 15:46:27 +0100 From: Greg KH To: Chetan Sethi Cc: devel@driverdev.osuosl.org, punitvara@gmail.com, wsa@the-dreams.de, linux-kernel@vger.kernel.org, shiva@exdev.nl Subject: Re: [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Message-ID: <20170227144627.GA24022@kroah.com> References: <1488092374-17737-1-git-send-email-cpsethi369@gmail.com> <1488092482-17829-1-git-send-email-cpsethi369@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1488092482-17829-1-git-send-email-cpsethi369@gmail.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 26, 2017 at 04:01:22PM +0900, Chetan Sethi wrote: > This patch fixes error of enclosing complex macro value in parentheses, > error as issued by checkpatch > > Signed-off-by: Chetan Sethi > --- > v2: > - split multiple changes across different patches > v3: > - mentioned patch revision in subject > - incorporated review comment of correct indentation for do statement > v4: > - modified description to exclude mention of patch number from changelog > > drivers/staging/ks7010/ks_wlan.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h > index 668202d..33d6b28 100644 > --- a/drivers/staging/ks7010/ks_wlan.h > +++ b/drivers/staging/ks7010/ks_wlan.h > @@ -36,8 +36,10 @@ > > #ifdef KS_WLAN_DEBUG > #define DPRINTK(n, fmt, args...) \ > - if (KS_WLAN_DEBUG > (n)) \ > - printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) > + do { \ This line is not correct, again, it's ok if existing code has checkpatch issues, but you should never _add_ any new ones. Please fix this up and resend the series. thanks, greg k-h