* [PATCH v4 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters
@ 2017-02-26 6:59 Chetan Sethi
2017-02-26 7:01 ` [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi
` (4 more replies)
0 siblings, 5 replies; 14+ messages in thread
From: Chetan Sethi @ 2017-02-26 6:59 UTC (permalink / raw)
To: gregkh; +Cc: wsa, shiva, punitvara, devel, linux-kernel, Chetan Sethi
This patch fixes warning of line over 80 characters, as issued by
checkpatch.pl
Signed-off-by: Chetan Sethi <cpsethi369@gmail.com>
---
v2:
- split multiple changes across different patches
v3:
- mentioned patch revision in subject
v4:
- modified description to exclude mention of patch number from changelog
drivers/staging/ks7010/ks_wlan.h | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h
index 9ab80e1..668202d 100644
--- a/drivers/staging/ks7010/ks_wlan.h
+++ b/drivers/staging/ks7010/ks_wlan.h
@@ -18,10 +18,10 @@
#include <linux/kernel.h>
#include <linux/module.h>
-#include <linux/spinlock.h> /* spinlock_t */
-#include <linux/sched.h> /* wait_queue_head_t */
-#include <linux/types.h> /* pid_t */
-#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */
+#include <linux/spinlock.h> /* spinlock_t */
+#include <linux/sched.h> /* wait_queue_head_t */
+#include <linux/types.h> /* pid_t */
+#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */
#include <linux/etherdevice.h>
#include <linux/wireless.h>
#include <linux/atomic.h> /* struct atomic_t */
@@ -36,7 +36,8 @@
#ifdef KS_WLAN_DEBUG
#define DPRINTK(n, fmt, args...) \
- if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
+ if (KS_WLAN_DEBUG > (n)) \
+ printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args)
#else
#define DPRINTK(n, fmt, args...)
#endif
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread* [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses 2017-02-26 6:59 [PATCH v4 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi @ 2017-02-26 7:01 ` Chetan Sethi 2017-02-27 14:46 ` Greg KH 2017-02-26 7:01 ` [PATCH v4 3/6] staging: ks7010: fix coding style issue of using tabs instead of spaces Chetan Sethi ` (3 subsequent siblings) 4 siblings, 1 reply; 14+ messages in thread From: Chetan Sethi @ 2017-02-26 7:01 UTC (permalink / raw) To: gregkh; +Cc: wsa, shiva, punitvara, devel, linux-kernel, Chetan Sethi This patch fixes error of enclosing complex macro value in parentheses, error as issued by checkpatch Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject - incorporated review comment of correct indentation for do statement v4: - modified description to exclude mention of patch number from changelog drivers/staging/ks7010/ks_wlan.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 668202d..33d6b28 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -36,8 +36,10 @@ #ifdef KS_WLAN_DEBUG #define DPRINTK(n, fmt, args...) \ - if (KS_WLAN_DEBUG > (n)) \ - printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) + do { \ + if (KS_WLAN_DEBUG > (n)) \ + printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \ + } while (0) #else #define DPRINTK(n, fmt, args...) #endif -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses 2017-02-26 7:01 ` [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi @ 2017-02-27 14:46 ` Greg KH 2017-02-28 2:59 ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi 0 siblings, 1 reply; 14+ messages in thread From: Greg KH @ 2017-02-27 14:46 UTC (permalink / raw) To: Chetan Sethi; +Cc: devel, punitvara, wsa, linux-kernel, shiva On Sun, Feb 26, 2017 at 04:01:22PM +0900, Chetan Sethi wrote: > This patch fixes error of enclosing complex macro value in parentheses, > error as issued by checkpatch > > Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> > --- > v2: > - split multiple changes across different patches > v3: > - mentioned patch revision in subject > - incorporated review comment of correct indentation for do statement > v4: > - modified description to exclude mention of patch number from changelog > > drivers/staging/ks7010/ks_wlan.h | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h > index 668202d..33d6b28 100644 > --- a/drivers/staging/ks7010/ks_wlan.h > +++ b/drivers/staging/ks7010/ks_wlan.h > @@ -36,8 +36,10 @@ > > #ifdef KS_WLAN_DEBUG > #define DPRINTK(n, fmt, args...) \ > - if (KS_WLAN_DEBUG > (n)) \ > - printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) > + do { \ This line is not correct, again, it's ok if existing code has checkpatch issues, but you should never _add_ any new ones. Please fix this up and resend the series. thanks, greg k-h ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters 2017-02-27 14:46 ` Greg KH @ 2017-02-28 2:59 ` Chetan Sethi 2017-02-28 3:00 ` [PATCH v5 2/5] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi ` (4 more replies) 0 siblings, 5 replies; 14+ messages in thread From: Chetan Sethi @ 2017-02-28 2:59 UTC (permalink / raw) To: gregkh; +Cc: devel, punitvara, wsa, linux-kernel, shiva, Chetan Sethi This patch fixes warning of line over 80 characters, as issued by checkpatch.pl Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject v4: - modified description to exclude mention of patch number from changelog v5: - updated series for removing additional checkpatch error introduced drivers/staging/ks7010/ks_wlan.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 9ab80e1..668202d 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -18,10 +18,10 @@ #include <linux/kernel.h> #include <linux/module.h> -#include <linux/spinlock.h> /* spinlock_t */ -#include <linux/sched.h> /* wait_queue_head_t */ -#include <linux/types.h> /* pid_t */ -#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ +#include <linux/spinlock.h> /* spinlock_t */ +#include <linux/sched.h> /* wait_queue_head_t */ +#include <linux/types.h> /* pid_t */ +#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ #include <linux/etherdevice.h> #include <linux/wireless.h> #include <linux/atomic.h> /* struct atomic_t */ @@ -36,7 +36,8 @@ #ifdef KS_WLAN_DEBUG #define DPRINTK(n, fmt, args...) \ - if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) + if (KS_WLAN_DEBUG > (n)) \ + printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) #else #define DPRINTK(n, fmt, args...) #endif -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v5 2/5] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses 2017-02-28 2:59 ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi @ 2017-02-28 3:00 ` Chetan Sethi 2017-02-28 3:00 ` [PATCH v5 3/5] staging: ks7010: fix coding style issue of using pr_notice instead of printk Chetan Sethi ` (3 subsequent siblings) 4 siblings, 0 replies; 14+ messages in thread From: Chetan Sethi @ 2017-02-28 3:00 UTC (permalink / raw) To: gregkh; +Cc: devel, punitvara, wsa, linux-kernel, shiva, Chetan Sethi This patch fixes error of enclosing complex macro value in parentheses, error as issued by checkpatch Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject - incorporated review comment of correct indentation for do statement v4: - modified description to exclude mention of patch number from changelog v5: - updated series for removing additional checkpatch error introduced drivers/staging/ks7010/ks_wlan.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 668202d..94b648b 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -36,8 +36,10 @@ #ifdef KS_WLAN_DEBUG #define DPRINTK(n, fmt, args...) \ - if (KS_WLAN_DEBUG > (n)) \ - printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) + do { \ + if (KS_WLAN_DEBUG > (n)) \ + printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \ + } while (0) #else #define DPRINTK(n, fmt, args...) #endif -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v5 3/5] staging: ks7010: fix coding style issue of using pr_notice instead of printk 2017-02-28 2:59 ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi 2017-02-28 3:00 ` [PATCH v5 2/5] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi @ 2017-02-28 3:00 ` Chetan Sethi 2017-02-28 3:01 ` [PATCH v5 4/5] staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__ Chetan Sethi ` (2 subsequent siblings) 4 siblings, 0 replies; 14+ messages in thread From: Chetan Sethi @ 2017-02-28 3:00 UTC (permalink / raw) To: gregkh; +Cc: devel, punitvara, wsa, linux-kernel, shiva, Chetan Sethi Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject v4: - modified description to exclude mention of patch number from changelog - updated subject to include driver name v5: - updated series for removing additional checkpatch error introduced drivers/staging/ks7010/ks_wlan.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 94b648b..78beca7 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -38,7 +38,7 @@ #define DPRINTK(n, fmt, args...) \ do { \ if (KS_WLAN_DEBUG > (n)) \ - printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \ + pr_notice("%s: "fmt, __FUNCTION__, ## args); \ } while (0) #else #define DPRINTK(n, fmt, args...) -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v5 4/5] staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__ 2017-02-28 2:59 ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi 2017-02-28 3:00 ` [PATCH v5 2/5] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi 2017-02-28 3:00 ` [PATCH v5 3/5] staging: ks7010: fix coding style issue of using pr_notice instead of printk Chetan Sethi @ 2017-02-28 3:01 ` Chetan Sethi 2017-02-28 3:01 ` [PATCH v5 5/5] staging: ks7010: fix coding style issue of aligning comments properly Chetan Sethi 2017-02-28 19:26 ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Greg KH 4 siblings, 0 replies; 14+ messages in thread From: Chetan Sethi @ 2017-02-28 3:01 UTC (permalink / raw) To: gregkh; +Cc: devel, punitvara, wsa, linux-kernel, shiva, Chetan Sethi This patch fixes coding style issue of using __func__ instead of gcc specific __FUNCTION__, warning as issued by checkpatch Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject v4: - modified description to exclude mention of patch number from changelog - updated subject to include driver name v5: - updated series for removing additional checkpatch error introduced drivers/staging/ks7010/ks_wlan.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 78beca7..79737bf 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -38,7 +38,7 @@ #define DPRINTK(n, fmt, args...) \ do { \ if (KS_WLAN_DEBUG > (n)) \ - pr_notice("%s: "fmt, __FUNCTION__, ## args); \ + pr_notice("%s: "fmt, __func__, ## args); \ } while (0) #else #define DPRINTK(n, fmt, args...) -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v5 5/5] staging: ks7010: fix coding style issue of aligning comments properly 2017-02-28 2:59 ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi ` (2 preceding siblings ...) 2017-02-28 3:01 ` [PATCH v5 4/5] staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__ Chetan Sethi @ 2017-02-28 3:01 ` Chetan Sethi 2017-02-28 19:26 ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Greg KH 4 siblings, 0 replies; 14+ messages in thread From: Chetan Sethi @ 2017-02-28 3:01 UTC (permalink / raw) To: gregkh; +Cc: devel, punitvara, wsa, linux-kernel, shiva, Chetan Sethi This patch fixes coding style issue of having block comments using a trailing */ on a separate line, warning as issued by checkpatch Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject v4: - modified description to exclude mention of patch number from changelog - updated subject to include driver name v5: - updated series for removing additional checkpatch error introduced drivers/staging/ks7010/ks_wlan.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 79737bf..1a63704 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -359,7 +359,8 @@ struct wpa_key_t { u8 rx_seq[IW_ENCODE_SEQ_MAX_SIZE]; /* LSB first */ struct sockaddr addr; /* ff:ff:ff:ff:ff:ff for broadcast/multicast * (group) keys or unicast address for - * individual keys */ + * individual keys + */ u16 alg; u16 key_len; /* WEP: 5 or 13, TKIP: 32, CCMP: 16 */ u8 key_val[IW_ENCODING_TOKEN_MAX]; -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters 2017-02-28 2:59 ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi ` (3 preceding siblings ...) 2017-02-28 3:01 ` [PATCH v5 5/5] staging: ks7010: fix coding style issue of aligning comments properly Chetan Sethi @ 2017-02-28 19:26 ` Greg KH 2017-02-28 19:27 ` Greg KH 4 siblings, 1 reply; 14+ messages in thread From: Greg KH @ 2017-02-28 19:26 UTC (permalink / raw) To: Chetan Sethi; +Cc: devel, punitvara, wsa, linux-kernel, shiva On Tue, Feb 28, 2017 at 11:59:36AM +0900, Chetan Sethi wrote: > This patch fixes warning of line over 80 characters, as issued by > checkpatch.pl > > Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> > --- > v2: > - split multiple changes across different patches > v3: > - mentioned patch revision in subject > v4: > - modified description to exclude mention of patch number from changelog > v5: > - updated series for removing additional checkpatch error introduced > > drivers/staging/ks7010/ks_wlan.h | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h > index 9ab80e1..668202d 100644 > --- a/drivers/staging/ks7010/ks_wlan.h > +++ b/drivers/staging/ks7010/ks_wlan.h > @@ -18,10 +18,10 @@ > #include <linux/kernel.h> > #include <linux/module.h> > > -#include <linux/spinlock.h> /* spinlock_t */ > -#include <linux/sched.h> /* wait_queue_head_t */ > -#include <linux/types.h> /* pid_t */ > -#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ > +#include <linux/spinlock.h> /* spinlock_t */ > +#include <linux/sched.h> /* wait_queue_head_t */ > +#include <linux/types.h> /* pid_t */ > +#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ > #include <linux/etherdevice.h> > #include <linux/wireless.h> > #include <linux/atomic.h> /* struct atomic_t */ > @@ -36,7 +36,8 @@ > > #ifdef KS_WLAN_DEBUG > #define DPRINTK(n, fmt, args...) \ > - if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) > + if (KS_WLAN_DEBUG > (n)) \ Why did you not use a tab here to indent this line as you were modifying it? thanks, greg k-h ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters 2017-02-28 19:26 ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Greg KH @ 2017-02-28 19:27 ` Greg KH 0 siblings, 0 replies; 14+ messages in thread From: Greg KH @ 2017-02-28 19:27 UTC (permalink / raw) To: Chetan Sethi; +Cc: devel, punitvara, wsa, linux-kernel, shiva On Tue, Feb 28, 2017 at 08:26:19PM +0100, Greg KH wrote: > On Tue, Feb 28, 2017 at 11:59:36AM +0900, Chetan Sethi wrote: > > This patch fixes warning of line over 80 characters, as issued by > > checkpatch.pl > > > > Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> > > --- > > v2: > > - split multiple changes across different patches > > v3: > > - mentioned patch revision in subject > > v4: > > - modified description to exclude mention of patch number from changelog > > v5: > > - updated series for removing additional checkpatch error introduced > > > > drivers/staging/ks7010/ks_wlan.h | 11 ++++++----- > > 1 file changed, 6 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h > > index 9ab80e1..668202d 100644 > > --- a/drivers/staging/ks7010/ks_wlan.h > > +++ b/drivers/staging/ks7010/ks_wlan.h > > @@ -18,10 +18,10 @@ > > #include <linux/kernel.h> > > #include <linux/module.h> > > > > -#include <linux/spinlock.h> /* spinlock_t */ > > -#include <linux/sched.h> /* wait_queue_head_t */ > > -#include <linux/types.h> /* pid_t */ > > -#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ > > +#include <linux/spinlock.h> /* spinlock_t */ > > +#include <linux/sched.h> /* wait_queue_head_t */ > > +#include <linux/types.h> /* pid_t */ > > +#include <linux/netdevice.h> /* struct net_device_stats, struct sk_buff */ > > #include <linux/etherdevice.h> > > #include <linux/wireless.h> > > #include <linux/atomic.h> /* struct atomic_t */ > > @@ -36,7 +36,8 @@ > > > > #ifdef KS_WLAN_DEBUG > > #define DPRINTK(n, fmt, args...) \ > > - if (KS_WLAN_DEBUG > (n)) printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args) > > + if (KS_WLAN_DEBUG > (n)) \ > > Why did you not use a tab here to indent this line as you were modifying > it? Oh nevermind, you change this up later on in the series... ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v4 3/6] staging: ks7010: fix coding style issue of using tabs instead of spaces 2017-02-26 6:59 [PATCH v4 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi 2017-02-26 7:01 ` [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi @ 2017-02-26 7:01 ` Chetan Sethi 2017-02-26 7:02 ` [PATCH v4 4/6] staging: ks7010: fix coding style issue of using pr_notice instead of printk Chetan Sethi ` (2 subsequent siblings) 4 siblings, 0 replies; 14+ messages in thread From: Chetan Sethi @ 2017-02-26 7:01 UTC (permalink / raw) To: gregkh; +Cc: wsa, shiva, punitvara, devel, linux-kernel, Chetan Sethi This patch fixes coding style issue of using tabs instead of spaces at start of line, error as issued by checkpatch.pl Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject v4: - modified description to exclude mention of patch number from changelog drivers/staging/ks7010/ks_wlan.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 33d6b28..94b648b 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -36,7 +36,7 @@ #ifdef KS_WLAN_DEBUG #define DPRINTK(n, fmt, args...) \ - do { \ + do { \ if (KS_WLAN_DEBUG > (n)) \ printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \ } while (0) -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v4 4/6] staging: ks7010: fix coding style issue of using pr_notice instead of printk 2017-02-26 6:59 [PATCH v4 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi 2017-02-26 7:01 ` [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi 2017-02-26 7:01 ` [PATCH v4 3/6] staging: ks7010: fix coding style issue of using tabs instead of spaces Chetan Sethi @ 2017-02-26 7:02 ` Chetan Sethi 2017-02-26 7:02 ` [PATCH v4 5/6] staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__ Chetan Sethi 2017-02-26 7:03 ` [PATCH v4 6/6] staging: ks7010: fix coding style issue of aligning comments properly Chetan Sethi 4 siblings, 0 replies; 14+ messages in thread From: Chetan Sethi @ 2017-02-26 7:02 UTC (permalink / raw) To: gregkh; +Cc: wsa, shiva, punitvara, devel, linux-kernel, Chetan Sethi This patch fixes coding style issue of using pr_notice instead of printk, warning as issued by checkpatch.pl Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject v4: - modified description to exclude mention of patch number from changelog - updated subject to include driver name drivers/staging/ks7010/ks_wlan.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 94b648b..78beca7 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -38,7 +38,7 @@ #define DPRINTK(n, fmt, args...) \ do { \ if (KS_WLAN_DEBUG > (n)) \ - printk(KERN_NOTICE "%s: "fmt, __FUNCTION__, ## args); \ + pr_notice("%s: "fmt, __FUNCTION__, ## args); \ } while (0) #else #define DPRINTK(n, fmt, args...) -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v4 5/6] staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__ 2017-02-26 6:59 [PATCH v4 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi ` (2 preceding siblings ...) 2017-02-26 7:02 ` [PATCH v4 4/6] staging: ks7010: fix coding style issue of using pr_notice instead of printk Chetan Sethi @ 2017-02-26 7:02 ` Chetan Sethi 2017-02-26 7:03 ` [PATCH v4 6/6] staging: ks7010: fix coding style issue of aligning comments properly Chetan Sethi 4 siblings, 0 replies; 14+ messages in thread From: Chetan Sethi @ 2017-02-26 7:02 UTC (permalink / raw) To: gregkh; +Cc: wsa, shiva, punitvara, devel, linux-kernel, Chetan Sethi This patch fixes coding style issue of using __func__ instead of gcc specific __FUNCTION__, warning as issued by checkpatch Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject v4: - modified description to exclude mention of patch number from changelog - updated subject to include driver name drivers/staging/ks7010/ks_wlan.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 78beca7..79737bf 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -38,7 +38,7 @@ #define DPRINTK(n, fmt, args...) \ do { \ if (KS_WLAN_DEBUG > (n)) \ - pr_notice("%s: "fmt, __FUNCTION__, ## args); \ + pr_notice("%s: "fmt, __func__, ## args); \ } while (0) #else #define DPRINTK(n, fmt, args...) -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v4 6/6] staging: ks7010: fix coding style issue of aligning comments properly 2017-02-26 6:59 [PATCH v4 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi ` (3 preceding siblings ...) 2017-02-26 7:02 ` [PATCH v4 5/6] staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__ Chetan Sethi @ 2017-02-26 7:03 ` Chetan Sethi 4 siblings, 0 replies; 14+ messages in thread From: Chetan Sethi @ 2017-02-26 7:03 UTC (permalink / raw) To: gregkh; +Cc: wsa, shiva, punitvara, devel, linux-kernel, Chetan Sethi This patch fixes coding style issue of having block comments using a trailing */ on a separate line, warning as issued by checkpatch Signed-off-by: Chetan Sethi <cpsethi369@gmail.com> --- v2: - split multiple changes across different patches v3: - mentioned patch revision in subject v4: - modified description to exclude mention of patch number from changelog - updated subject to include driver name drivers/staging/ks7010/ks_wlan.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan.h b/drivers/staging/ks7010/ks_wlan.h index 79737bf..1a63704 100644 --- a/drivers/staging/ks7010/ks_wlan.h +++ b/drivers/staging/ks7010/ks_wlan.h @@ -359,7 +359,8 @@ struct wpa_key_t { u8 rx_seq[IW_ENCODE_SEQ_MAX_SIZE]; /* LSB first */ struct sockaddr addr; /* ff:ff:ff:ff:ff:ff for broadcast/multicast * (group) keys or unicast address for - * individual keys */ + * individual keys + */ u16 alg; u16 key_len; /* WEP: 5 or 13, TKIP: 32, CCMP: 16 */ u8 key_val[IW_ENCODING_TOKEN_MAX]; -- 2.7.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
end of thread, other threads:[~2017-02-28 19:36 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-02-26 6:59 [PATCH v4 1/6] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi 2017-02-26 7:01 ` [PATCH v4 2/6] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi 2017-02-27 14:46 ` Greg KH 2017-02-28 2:59 ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Chetan Sethi 2017-02-28 3:00 ` [PATCH v5 2/5] staging: ks7010: fix coding style issue of enclosing complex macro value in parentheses Chetan Sethi 2017-02-28 3:00 ` [PATCH v5 3/5] staging: ks7010: fix coding style issue of using pr_notice instead of printk Chetan Sethi 2017-02-28 3:01 ` [PATCH v5 4/5] staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__ Chetan Sethi 2017-02-28 3:01 ` [PATCH v5 5/5] staging: ks7010: fix coding style issue of aligning comments properly Chetan Sethi 2017-02-28 19:26 ` [PATCH v5 1/5] staging: ks7010: fixed warning of avoiding line over 80 characters Greg KH 2017-02-28 19:27 ` Greg KH 2017-02-26 7:01 ` [PATCH v4 3/6] staging: ks7010: fix coding style issue of using tabs instead of spaces Chetan Sethi 2017-02-26 7:02 ` [PATCH v4 4/6] staging: ks7010: fix coding style issue of using pr_notice instead of printk Chetan Sethi 2017-02-26 7:02 ` [PATCH v4 5/6] staging: ks7010: fix coding style issue of using __func__ instead of __FUNCTION__ Chetan Sethi 2017-02-26 7:03 ` [PATCH v4 6/6] staging: ks7010: fix coding style issue of aligning comments properly Chetan Sethi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox