From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751538AbdB0RdR (ORCPT ); Mon, 27 Feb 2017 12:33:17 -0500 Received: from quartz.orcorp.ca ([184.70.90.242]:55744 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbdB0RdQ (ORCPT ); Mon, 27 Feb 2017 12:33:16 -0500 Date: Mon, 27 Feb 2017 10:33:03 -0700 From: Jason Gunthorpe To: Jarkko Sakkinen Cc: James Bottomley , tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, dhowells@redhat.com, Peter Huewe , Marcel Selhorst , open list Subject: Re: [PATCH v2 6/7] tpm: expose spaces via a device link /dev/tpms Message-ID: <20170227173303.GI5891@obsidianresearch.com> References: <20170216192529.25467-1-jarkko.sakkinen@linux.intel.com> <20170216192529.25467-7-jarkko.sakkinen@linux.intel.com> <20170223090917.jq7thil5ggjmagil@intel.com> <1487941328.2249.23.camel@HansenPartnership.com> <20170226114440.5ksg3lx27ylekvbx@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170226114440.5ksg3lx27ylekvbx@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 26, 2017 at 01:44:40PM +0200, Jarkko Sakkinen wrote: > There's now tabrm-v3 branch. I had to tweak error handling in your > device adding patch because of b4e9d7561a70. I hope I didn't break > anything. Just looked, the flow seemed like it works to me. Just confusing that tpm_add_char_device isn't undone by tpm_del_char_device Jason