From: "Tobin C. Harding" <me@tobin.cc>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Arushi Singhal <arushisinghal19971997@gmail.com>,
devel@driverdev.osuosl.org, Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code in comments.
Date: Tue, 28 Feb 2017 07:29:15 +1100 [thread overview]
Message-ID: <20170227202915.GA10862@eros> (raw)
In-Reply-To: <alpine.DEB.2.20.1702271606420.3032@hadrien>
On Mon, Feb 27, 2017 at 04:07:27PM +0100, Julia Lawall wrote:
>
>
> On Mon, 27 Feb 2017, Arushi Singhal wrote:
>
> >
> >
> > On Mon, Feb 27, 2017 at 8:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
> > > Commenting Code Is a Bad Idea.
> > > Comments are their to explain the code and how the code
> > achieves its
> > > goal and as codes in the comments does not explain what the
> > code is
> > > doing so there is no use of commenting them.
> > > So in this patch codes in the comments are removed.
> > >
> > > Signed-off-by: Arushi Singhal
> > <arushisinghal19971997@gmail.com>
> > > ---
> > > changes in v2
> > > - subject lines is made short.
> > >
> > > drivers/staging/ks7010/ks7010_sdio.c | 4 ----
> > > 1 file changed, 4 deletions(-)
> >
> > This patch does not apply against my staging-testing branch :(
> >
> >
> > why?
>
> You should figure this out yourself. Pull Greg's tree again, and try to
> apply your patch. It's deterministic, so you should have the same
> information that he has.
I have only just worked this out Arushi so I thought I'd share. You
may want to read up on remote tracking branches in git and set up a
branch tracking Greg's staging-testing branch. Then create (checkout
-b) your development branches from that branch.
Good luck,
Tobin.
prev parent reply other threads:[~2017-02-27 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 16:08 [PATCH v2] staging: ks7010: remove code in comments Arushi Singhal
2017-02-27 14:48 ` Greg KH
[not found] ` <CA+XqjF-7SfgGkcHGhraz2R=8qV4Vgqiky+u+qSJNTMGr__JnTg@mail.gmail.com>
2017-02-27 15:07 ` [Outreachy kernel] " Julia Lawall
2017-02-27 20:29 ` Tobin C. Harding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227202915.GA10862@eros \
--to=me@tobin.cc \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox